Skip to content

Commit

Permalink
FSE: Don't run GitHub Action on yarn.lock change (#43480)
Browse files Browse the repository at this point in the history
Addresses #43458 (comment): In #43458, we added a job to PHPCS lint any changed files in the FSE plugin directory. Additionally, we started triggering that action (that's also in charge of creating the FSE diff for WP.com) upon changes to `yarn.lock`.

Turns out that this is too broad a criterion, since `yarn.lock` will change everytime e.g. a Renovate PR is created -- thus creating those FSE diffs too often. While we can consider triggering diff generation upon npm dependency changes, that is an orthogonal change to adding PHPCS linting, so IMO it's fine to remove it -- it's not a regression over the GH Action's state prior to #43458.
  • Loading branch information
ockham authored Jun 19, 2020
1 parent db3db77 commit 19c7223
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/full-site-editing-plugin.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ on:
# only trigger this workflow if FSE plugin files have been modified, or if packages have been updated.
paths:
- 'apps/full-site-editing/**'
- 'yarn.lock'

name: FSE plugin

Expand Down

0 comments on commit 19c7223

Please sign in to comment.