Skip to content

Commit

Permalink
Use globalThis on jsdoc
Browse files Browse the repository at this point in the history
  • Loading branch information
mmtr committed Jan 16, 2020
1 parent f2d1f74 commit 5d434f3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 7 deletions.
2 changes: 0 additions & 2 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,6 @@ module.exports = {
globalThis: true,
window: true,
document: true,
File: true,
XMLHttpRequest: true,
// this is our custom function that's transformed by babel into either a dynamic import or a normal require
asyncRequire: true,
// this is the SHA of the current commit. Injected at boot in a script tag.
Expand Down
10 changes: 5 additions & 5 deletions client/lib/wpcom-undocumented/lib/undocumented.js
Original file line number Diff line number Diff line change
Expand Up @@ -2147,9 +2147,9 @@ Undocumented.prototype.exportReaderFeed = function( fn ) {
* Imports given XML file into the user's Reader feed.
* XML file is expected to be in OPML format.
*
* @param {File} file The File object to upload
* @param {globalThis.File} file The File object to upload
* @param {Function} fn The callback function
* @returns {XMLHttpRequest} The XHR instance, to attach `progress`
* @returns {globalThis.XMLHttpRequest} The XHR instance, to attach `progress`
* listeners to, etc.
*/
Undocumented.prototype.importReaderFeed = function( file, fn ) {
Expand All @@ -2173,7 +2173,7 @@ Undocumented.prototype.importReaderFeed = function( file, fn ) {
* @param {string} deviceFamily The device family
* @param {string} deviceName The device name
* @param {Function} fn The callback function
* @returns {XMLHttpRequest} The XHR instance
* @returns {globalThis.XMLHttpRequest} The XHR instance
*/
Undocumented.prototype.registerDevice = function( registration, deviceFamily, deviceName, fn ) {
debug( '/devices/new' );
Expand All @@ -2194,7 +2194,7 @@ Undocumented.prototype.registerDevice = function( registration, deviceFamily, de
*
* @param {number} deviceId The device ID for the registration to be removed
* @param {Function} fn The callback function
* @returns {XMLHttpRequest} The XHR instance
* @returns {globalThis.XMLHttpRequest} The XHR instance
*/
Undocumented.prototype.unregisterDevice = function( deviceId, fn ) {
debug( '/devices/:device_id/delete' );
Expand All @@ -2218,7 +2218,7 @@ Undocumented.prototype.wordAdsApprove = function( siteId ) {
*
* @param {number} siteId -- the ID of the site
* @param {string} [plugin] -- .org plugin slug
* @param {File} [theme] -- theme zip to upload
* @param {globalThis.File} [theme] -- theme zip to upload
* @param {Function} [onProgress] -- called with upload progress status
*
* @returns {Promise} promise for handling result
Expand Down

0 comments on commit 5d434f3

Please sign in to comment.