Skip to content

Commit

Permalink
Merge pull request #651 from Automattic/add/how-to-ask-for-review-in-…
Browse files Browse the repository at this point in the history
…contributing-md

DevDocs/Contributing: Add tips for choosing a code reviewer in CONTRIBUTING.md
  • Loading branch information
codebykat committed Nov 24, 2015
2 parents ff4ac6a + a156f82 commit b60cdc3
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,14 @@ Code reviews are an important part of the Calypso workflow. They help to keep co

Every PR should be reviewed and approved by someone other than the author, even if the author has write access. Fresh eyes can find problems that can hide in the open if you’ve been working on the code for a while.

The recommended way of finding an appropriate person to review your code is by [blaming](https://help.github.com/articles/using-git-blame-to-trace-changes-in-a-file/) one of the files you are updating and looking at who was responsible for previous commits on that file.

Then, you may ask that person to review your code by mentioning his/her GitHub username on the PR comments like this:

```
cc @username
```

*Everyone* is encouraged to review PRs and add feedback and ask questions, even people who are new to Calypso. Also, don’t just review PRs about what you’re working on. Reading other people’s code is a great way to learn new techniques, and seeing code outside of your own feature helps you to see patterns across the project. It’s also helpful to see the feedback other contributors are getting on their PRs.

### Coding Standards & Guidelines
Expand Down

0 comments on commit b60cdc3

Please sign in to comment.