Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: Refactor theme-options #1620

Closed
ockham opened this issue Dec 15, 2015 · 0 comments
Closed

Themes: Refactor theme-options #1620

ockham opened this issue Dec 15, 2015 · 0 comments
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Task

Comments

@ockham
Copy link
Contributor

ockham commented Dec 15, 2015

In order to get rid of some more of the ugliness that is my-sites/themes/main.jsx, we'll need to refactor theme-options. In main.jsx, we're now passing props selectedAction (a string), actions, and getOptions to ThemesSiteSelectorModal. Ideally, I think it should be just a selectedAction function -- something that is currently computed inside ThemesSiteSelectorModal. Urgh.

(From #840 (comment))
@ockham ockham added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Task labels Dec 15, 2015
This was referenced Jan 13, 2016
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Type] Task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ockham