Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Themes: Refactor themes-options #2307

Closed
wants to merge 3 commits into from
Closed

Conversation

ockham
Copy link
Contributor

@ockham ockham commented Jan 12, 2016

Kill, kill, kill for peace.

Addresses #1620.

Some ideas:

  • Ideally, the getButtonOptions call (or equivalent) would not happen until the ​_more_​ button is clicked ((c) by @seear)
  • Reduce arguments to getButtonOptions
    • Don't pass actions. Instead, just return the Redux action for further dispatching by the consumer
    • Don't pass theme, site, and isLoggedOut. Instead, make isHidden a function accepting those directly.
  • For clarity's sake, return an object from getButtonOptions (with what's currently the name as the key) instead of an array (I have code locally for that)

@ockham ockham added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] In Progress labels Jan 12, 2016
@ockham ockham self-assigned this Jan 12, 2016
@ockham ockham force-pushed the refactor/themes-options branch from d38dbe6 to a1aeba5 Compare January 12, 2016 12:40
@ockham
Copy link
Contributor Author

ockham commented Jan 13, 2016

Closing in favor of #2378.

@ockham ockham closed this Jan 13, 2016
@ockham ockham deleted the refactor/themes-options branch January 13, 2016 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants