-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standards: CSSTransitionGroup
#220
Labels
Comments
This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week. If you would like it to remain open, can you please comment below and see what you can do to get things moving with this issue? Thanks! 🙏 |
jsnajdr
pushed a commit
that referenced
this issue
Jan 27, 2020
Update wpcom-xhr-request to 1.1.1 and use a caret version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Raised by @adambbecker
Since we're starting to utilize certain animation techniques more and more, one particular use case has arisen that probably should have some of "coding guidelines" thought put into it, the
CSSTransitionGroup
.We have a few guidelines already in place for handling some standard CSS/SASS conventions, but since the classes used by
CSSTransitionGroup
have some established naming conventions of their own (mainly.*-enter
/.*-enter-active
, etc.) and don't necessary have those classes applied directly to components; we probably should come up with a standardized way of our own.One idea to start would be something along the lines of:
We should prefix the animations. Suggestions:
Could these be done in a way that could be reused? Because then we could wrap
ReactCSSTransitionGroup
in helper components likeTransitionSlide
,TransitionBouncyFade
, etc.Which would mean the classes could become:
In the date-picker transition there doesn't seem to be anything specific style wise to the date picker. But even if there were, we could apply our
is-mod
principle to build on top of it and do:The text was updated successfully, but these errors were encountered: