Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purchases: style issues for PayPal in Edit Payment Method #272

Closed
fabianapsimoes opened this issue Nov 20, 2015 · 3 comments
Closed

Purchases: style issues for PayPal in Edit Payment Method #272

fabianapsimoes opened this issue Nov 20, 2015 · 3 comments
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug

Comments

@fabianapsimoes
Copy link
Contributor

This is how a PayPal account looks in Edit Payment Method:

paypal

This is what a store credit card looks like in comparison:

cc

We should probably add some space between the PayPal logo and the account name, and also make it bold so it matches the styles for credit cards.

@mikeshelton1503 proposed the following solution:

image

@fabianapsimoes fabianapsimoes added [Type] Bug Design [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 20, 2015
@fabianapsimoes fabianapsimoes added this to the Purchases: v1 milestone Nov 20, 2015
@drewblaisdell
Copy link
Contributor

I'm not (consciously 💭) trying to move every issue to Purchases v2, but since this issue was created, EditPaymentMethod is no longer mounted on any route and no longer contains PaymentLogo. It will be easier to make this change/test it when payment management is in progress again.

I opened #707 to add an isCompact prop to PaymentLogo, so that we can display the 'P' in the design with <PaymentLogo type="paypal" isCompact />

@fabianapsimoes
Copy link
Contributor Author

Makes sense, Drew. Punting the rest of this to v2.

@fabianapsimoes fabianapsimoes modified the milestones: Purchases: v2, Purchases: v1 Nov 25, 2015
@fabianapsimoes fabianapsimoes modified the milestones: Purchases: v2, Purchases: Future Feb 25, 2016
@fabianapsimoes
Copy link
Contributor Author

Closing this since we're not mounting Edit Payment Method on any routes, as Drew mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Bug
Projects
None yet
Development

No branches or pull requests

3 participants