Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Add isCompact prop to PaymentLogo #707

Merged
merged 3 commits into from
Nov 25, 2015
Merged

Components: Add isCompact prop to PaymentLogo #707

merged 3 commits into from
Nov 25, 2015

Conversation

drewblaisdell
Copy link
Contributor

Addresses part of #272.

screen shot 2015-11-24 at 4 28 41 pm

This PR:

  • Adds a README for PaymentLogo.
  • Adds PaymentLogo to /devdocs/design
  • Adds an isCompact prop to PaymentLogo to determine if just the 'P' is displayed when the logo is a paypal logo.

Testing

  • Assert that the README is sensible.
  • Assert that PaymentLogo appears in /devdocs/design.
  • QA review
  • Code review

@drewblaisdell drewblaisdell added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Task [Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. labels Nov 25, 2015
@drewblaisdell drewblaisdell self-assigned this Nov 25, 2015
@drewblaisdell drewblaisdell added this to the Purchases: v1 milestone Nov 25, 2015
@drewblaisdell drewblaisdell changed the title Components: Add isCompact property to PaymentLogo Components: Add isCompact prop to PaymentLogo Nov 25, 2015
@drewblaisdell drewblaisdell mentioned this pull request Nov 25, 2015
Closed
@scruffian scruffian added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Nov 25, 2015
@scruffian
Copy link
Member

LGTM 👍

drewblaisdell added a commit that referenced this pull request Nov 25, 2015
@drewblaisdell
Merge pull request #707 from Automattic/update/paypal-logo
7790e31 
Components: Add `isCompact` prop to `PaymentLogo`
@drewblaisdell drewblaisdell merged commit 7790e31 into master Nov 25, 2015
@drewblaisdell drewblaisdell deleted the update/paypal-logo branch November 25, 2015 17:48
@snyk-bot snyk-bot mentioned this pull request Jan 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@drewblaisdell drewblaisdell

Labels
[Feature] Purchase Management Related to managing purchases such as subscriptions, plans, history, auto-renew, cancellation, etc. [Type] Task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewblaisdell @scruffian @fabianapsimoes