Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jetpack branding to the Inspector #27773

Closed
3 tasks
MichaelArestad opened this issue Oct 10, 2018 · 6 comments
Closed
3 tasks

Add Jetpack branding to the Inspector #27773

MichaelArestad opened this issue Oct 10, 2018 · 6 comments
Assignees
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg Jetpack [Type] Enhancement

Comments

@MichaelArestad
Copy link
Contributor

We need to add a Jetpack colophon of some sort to the block inspector for Jetpack blocks. Let's make it a reusable component so it will be the same across blocks.

Here is the latest design for it:

image

It's just the logo and a separator for now. It's the same SVG used in the Jetpack dashboard. I think we can further work out what we place here and, as I elaborate on here, p6TEKc-23j , we could potentially put more information on it specific to each block.

Let's get it added to these blocks:

  • Markdown
  • Tiled Galleries
  • Related Posts

@mapk and @thomasguillot I would love some feedback and ideas from you to around this and what we could do in future iterations.

@tyxla
Copy link
Member

tyxla commented Oct 17, 2018

I'm re-grabbing this, as I already had something done locally.

@tyxla
Copy link
Member

tyxla commented Oct 17, 2018

And there it is: #27901

@MichaelArestad
Copy link
Contributor Author

I think we might sit on this for a bit. Don't start without pinging me.

@simison
Copy link
Member

simison commented Jan 23, 2019

@scruffian I suppose we can close this since we have Jetpack branding for block category now?

image

There is no indication of Jetpack once the block is in the editor, tho:

image

Another place where we have Jetpack branding is the plugin sidebar:

image

Would be neat to have the logo in the dropdown, too:

image

@tyxla
Copy link
Member

tyxla commented Jan 23, 2019

Would be neat to have the logo in the dropdown, too:

Noting that this is by design in the Gutenberg core. If we're currently looking at the plugin sidebar, a checkmark will be displayed in the dropdown, but if you select another plugin or another view (inspector controls for example), and click on the ... button, you should see the Jetpack icon in the dropdown, to the left of the "Jetpack" item.

@scruffian
Copy link
Member

I agree that this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Goal] Gutenberg Working towards full integration with Gutenberg Jetpack [Type] Enhancement
Projects
None yet
Development

No branches or pull requests

4 participants