Gutenberg: Add Jetpack colophon to Jetpack blocks #27901
Conversation
tyxla
added
Jetpack
[Status] Needs Review
|
That's a great PR description, thank you so much for your effort! Generated by 🚫 dangerJS |
|
|
||
| const JetpackBranding = () => ( | ||
| <InspectorControls> | ||
| <div className="jetpack-branding"> |
There was a problem hiding this comment.
Can we set the className directly on InspectorControls?
There was a problem hiding this comment.
No, we can't - which is why I did it that way.
| @@ -0,0 +1,23 @@ | |||
| /** @format */ | |||
There was a problem hiding this comment.
This is specific to the editor, should the file/Component name reflect that?
There was a problem hiding this comment.
Well, it's also specific to the sidebar in the editor - how specific should we get in the naming? I think it's good as-is, considering that there isn't a bunch of other components at this point 😉
sirreal
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
|
I believe a lot of design discussion around this has already happened, but the branding just seems way too obtrusive. It feels like an ad to me. The color, the size... it all seems like too much. And I think it sets a bad example for plugin developers. |
|
I think we have to site on this for the time being sadly. Thanks for putting this together. |
|
No worries - it was a good experiment, as we saw a use case for reusable components that make sense only in gutenberg context in Calypso. Should we close it for the time being @MichaelArestad? |
|
Yes. Just read an update around that. Let's close this for now. Thanks Marin! |
matticbot
removed
the
[Status] Needs Design Review
Changes proposed in this Pull Request
/componentsdirectory in/gutenbergthat we can use for reusable components that make sense only in Gutenberg context.JetpackBrandingcomponent that renders aJetpackLogowith an<hr />above, usingInspectorControls.Screenshots
Markdown:
Related Posts:
Tiled Gallery:
Testing instructions
Fixes #27773