Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled Galleries: Remove external block view dependencies #28933

Closed
3 tasks done
sirreal opened this issue Nov 29, 2018 · 3 comments
Closed
3 tasks done

Tiled Galleries: Remove external block view dependencies #28933

sirreal opened this issue Nov 29, 2018 · 3 comments
Assignees
Labels

Comments

@sirreal
Copy link
Member

sirreal commented Nov 29, 2018

Make view.js completely independent without externally enqueued dependencies. Current dependencies (via) are:

  • lodash
  • wp-i18n
  • wp-token-list

Lodash

Even if we just import small thing from lodash, the SDK externalizes it and we'd be required to enqueue all of lodash.

Another consideration is to change how SDK externalizes that library; perhaps only for editor.js?

wp-i18n

Due to usage of layout styles, Tiled Galleries block view depends on i18n although it doesn't display the localized strings. Find a solution.

Via https://github.com/Automattic/wp-calypso/pull/27458/files#r227411941

wp-token-list

Used to pick default style if none is found.

@sirreal sirreal added Jetpack [Type] Task [Goal] Gutenberg Working towards full integration with Gutenberg [Block] Tiled Gallery labels Nov 29, 2018
@simison
Copy link
Member

simison commented Nov 29, 2018

Let's try to have 0 view dependencies, 💪

@simison simison changed the title Tiled Galleries: Remove block view dependence on i18n Tiled Galleries: Remove block view dependencies Nov 30, 2018
@simison simison changed the title Tiled Galleries: Remove block view dependencies Tiled Galleries: Remove external block view dependencies Nov 30, 2018
@simison
Copy link
Member

simison commented Nov 30, 2018

Updated the issue to reflect removing all dependencies from view.js.

@sirreal
Copy link
Member Author

sirreal commented Feb 12, 2019

Fix in Automattic/jetpack#11326

I don't believe we ever had view dependencies when Tiled Gallery went into production blocks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants