Tiled Gallery: Move localized style labels into settings #30752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including the localized labels in the block constants implies that evaluating the module depended on calling the _x function provided by @wordpress/i18n. This lead to wp-i18n being a view-side dependency that provided no value. Reorganize so that localized labels are only available in the block settings where they are required.
sirreal
added
Jetpack
[Status] Needs Review
sirreal
added a commit
to Automattic/jetpack
that referenced
this pull request
Feb 13, 2019
With some restructuring, the dependency can be removed. Depends on: Automattic/wp-calypso#30752
simison
approved these changes
Feb 13, 2019
There was a problem hiding this comment.
Looks good!
Tested with Automattic/jetpack#11326 and confirmed this works in the editor and in view.
Confirmed that in view side window.wp.i18n wasn't available and the gallery still works. 👍
simison
added
[Status] Ready to Merge
and removed
[Status] Needs Review
jeherve
pushed a commit
to Automattic/jetpack
that referenced
this pull request
Feb 26, 2019
* Remove Tiled Gallery view deps * Restore wp-i18n dep * Drop wp-i18n again With some restructuring, the dependency can be removed. Depends on: Automattic/wp-calypso#30752 * Drop redundant empty dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the localized labels in the block constants implies that
evaluating the module depended on calling the _x function provided by
@wordpress/i18n. This lead to wp-i18n being a view-side dependency that
provided no value.
Reorganize so that localized labels are only available in the block
settings where they are required.
Required for #28933
Testing instructions
remove/tiled-gallery-view-dependenciesbranchhttps://jurassic.ninja/create?shortlived&gutenpack&gutenberg&calypsobranch=update/g7g-tg-restructure-drop-view-i18n-dep&branch=remove/tiled-gallery-view-dependencies