Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiled Gallery block: Open Link to Media File Opens Only that Image #29774

Closed
tmmbecker opened this issue Dec 28, 2018 · 2 comments
Closed

Tiled Gallery block: Open Link to Media File Opens Only that Image #29774

tmmbecker opened this issue Dec 28, 2018 · 2 comments

Comments

@tmmbecker
Copy link

With the old Tiled Galleries, linking to a Media file would load the images from the CDN in a carousel, including an option to close the carousel to return to the post.

screen shot on 2018-12-27 at 20-18-21 1

URL is https://tracyspress.net/2018/05/galleries-in-email/#jp-carousel-161

The Tiled Gallery block opens only the selected image in a lightbox-type window with no clear way to get back to my post:

screen shot on 2018-12-27 at 20-19-06
URL is https://i1.wp.com/testingplans.files.wordpress.com/2018/12/Screen-Shot-2018-09-20-at-10.58.20-AM.png?ssl=1&resize=404%2C404

Steps to Replicate:

  1. Create a Tiled Gallery.
  2. Select Media File as the Link to.
  3. Save the post and view it.
  4. Click one of the images in the tiled gallery.
@tmmbecker tmmbecker added [Type] Bug [Goal] Gutenberg Working towards full integration with Gutenberg [Block] Tiled Gallery labels Dec 28, 2018
@tmmbecker tmmbecker changed the title Tiled Gallery block: Open Link to Media File Opens Only that Image in the Same Tab Tiled Gallery block: Open Link to Media File Opens Only that Image Dec 28, 2018
@simison
Copy link
Member

simison commented Dec 28, 2018

We probably need to update something in Carousel JS in Jetpack, similarly like was done for Core Gallery: Automattic/jetpack#10646

Related:
Automattic/jetpack#11022
Automattic/jetpack#11024

cc @jeherve

@sirreal
Copy link
Member

sirreal commented Dec 28, 2018

Some related convo: p1545994003223100-slack-jetpack-gutenberg

If there is a core gallery and a tiled gallery block, the tiled gallery block is annotated incorrectly and the carousel doesn't work.

These will need updating:

https://github.com/Automattic/jetpack/blob/7cb3a5d9aeb5f3fd37d348f99094bc1cb33db8cb/modules/carousel/jetpack-carousel.php#L203

https://github.com/Automattic/jetpack/blob/7cb3a5d9aeb5f3fd37d348f99094bc1cb33db8cb/modules/carousel/jetpack-carousel.php#L480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants