Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the new markup of the Gutenberg Gallery blocks. #10646

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Handle the new markup of the Gutenberg Gallery blocks. #10646

merged 2 commits into from
Nov 19, 2018

Conversation

georgestephanis
Copy link
Member

No biggie just needed to handle the new markup and process

Fixes #10246

Testing instructions:

  • Make a Guten Gallery.
  • Do it?
  • It do.

Proposed changelog entry for your changes:

  • No changelog needed.

@georgestephanis georgestephanis added [Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Nov 16, 2018
@georgestephanis georgestephanis self-assigned this Nov 16, 2018
@georgestephanis georgestephanis requested a review from a team as a code owner November 16, 2018 00:53
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Please review this diff before merging: D20950-code. (newly created revision)

@jetpackbot
Copy link

Warnings
⚠️

The PR is missing at least one [Status] label. Suggestions: [Status] In Progress, [Status] Needs Review

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Nov 16, 2018
@jeherve jeherve added this to the 6.8 milestone Nov 16, 2018
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Nov 16, 2018
jeherve
jeherve approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It do! Nice work! 🚢

@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Please review this diff before merging: D20950-code. (updated diff)

@dereksmart
Copy link
Member

Was able to create a Guten Gallery and carousel seemed to work as expected. @georgestephanis Can you please take care of the Fusion diff? D20950-code

@dereksmart dereksmart merged commit 21379ab into master Nov 19, 2018
@dereksmart dereksmart deleted the fix/gutencarousel branch November 19, 2018 22:11
@ghost ghost removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 19, 2018
jeherve pushed a commit that referenced this pull request Nov 20, 2018
@jeherve
Handle the new markup of the Gutenberg Gallery blocks. (#10646)
2efbbbc 
* Handle the new markup of the Gutenberg Gallery blocks.

* Conditional to not die on old wp
@jeherve
Copy link
Member

jeherve commented Nov 20, 2018

Cherry-picked to branch-6.8 in 2efbbbc

jeherve added a commit that referenced this pull request Nov 20, 2018
@jeherve
changelog: add #10646
5fdd6b9
@MichaelArestad
Copy link
Contributor

Thanks for fixing this up @georgestephanis

@jeherve jeherve mentioned this pull request Nov 29, 2018
Closed
@kristarella kristarella mentioned this pull request Dec 5, 2018
Closed
@simison simison mentioned this pull request Dec 28, 2018
Closed
@kwight kwight mentioned this pull request Sep 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeherve jeherve jeherve approved these changes

@MichaelArestad MichaelArestad Awaiting requested review from MichaelArestad

Assignees

@georgestephanis georgestephanis

Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
6.8
Development

Successfully merging this pull request may close these issues.
6 participants
@georgestephanis @matticbot @jetpackbot @dereksmart @jeherve @MichaelArestad