-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carousel Not Loading on Gallery Blocks Added After Gutenberg 6.5 Update #36406
Comments
It looks like WordPress/gutenberg#17101 modified markup, that is likely important to the Jetpack carousel code. Investigating. |
Ran into this on 15348312-hc also confirmed on a test site |
Jetpack PR where carousel support was added: Automattic/jetpack#10646. This references |
Jetpack fix in progress: Automattic/jetpack#13582 |
Also reported on 2383880-zen |
Another report in https://en.forums.wordpress.com/topic/gallery-not-clickable/ - noting for follow-up once fixed. |
Another report in #2384009-zen. |
I have a user reporting the same issue but from a Simple site using the Classic editor. I am able to reproduce the same on a test site of my own. When the carousel option is selected under layout options, the link to "Attachment page" and "Media file' both do not open to the selected option. 2387435-zen |
Another report in 2387318-zen. |
Another report in #2386558-zen |
Another report in #2386416-zen |
Received another report in #2388326-zen However, an additional issue that appeared on this user's site - regardless of the attachment setting, if the gallery includes only one image, the carousel will not open (image is not clickable - except for "link to media file" which opens in a new page). |
Another report of this in #14065512-hc Followup in #2389042-zen |
Another report in #12697591-hc No follow up needed |
new report in: #14942807-hc |
This should be fixed on WordPress.com already. A fix will be included in Jetpack in version 7.9, scheduled to be released in early November. |
another report in #2388003-zen |
@jeherve Would this fix be in Jetpack beta? I'm trying to brainstorm how to fix this on Atomic so they don't have to wait a month since the fix is already done, right? |
@kriskarkoski It's in the current Bleeding Edge, yes. Here is the fix: |
@jeherve Noting that with Atomic being on Gutenberg 6.6 now, this gallery carousel issue is starting to pop up in tickets for Atomic sites. Is there an ETA on when the above fix will land on Atomic sites? |
@tijosh It will be early-November with the next Jetpack release unless we do a point release. Details at p9F6qB-496-p2 |
Steps to reproduce
Choose a simple site (should all have Gutenberg 6.5 now). Confirm that the carousel option is enabled under WP Admin > Settings > Media.
What I expected
Setting the "link to" option to "Media File" should open the images in the carousel, based on this support document:
https://en.support.wordpress.com/wordpress-editor/blocks/gallery-block/#linking
What happened instead
Setting the "link to" settings had the following results:
None = nothing opens, images not clickable
Media File = opens the individual media file
Attachment Page = mixed results. On some posts this opens the carousel, and on others I get non-clickable images.
Tested on Twenty Nineteen and on Lodestar (that was theme from the user-report)
Browser / OS version
Tested on Firefox 69.0.1 and Chrome 77.0.3865.90
Screenshot / Video - Example/Test Pages
Simple Site (free plan):
The gallery set to Attachment Pages loads the carousel
https://test1234444blog.wordpress.com/testcarousel/
Then another page on the same site set to Attachment Pages has non-clickable images
https://test1234444blog.wordpress.com/new-gallery-page/
Simple Site (free plan):
The gallery set to Attachment Pages loads the carousel here also:
https://test829463584.wordpress.com/2019/09/27/testing-gallery-blocks/
Jurassic Ninja Site w/ Gutenberg 6.5 plugin:
Gallery set to Attachment Pages has non-clickable images
https://spotty-polecat.jurassic.ninja/2019/09/27/gallery-test/
Context / Source
#user-report in #15519887-hc
The text was updated successfully, but these errors were encountered: