Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel Not Loading on Gallery Blocks Added After Gutenberg 6.5 Update #36406

Closed
katiebethbrown opened this issue Sep 27, 2019 · 22 comments
Closed
Assignees

Comments

@katiebethbrown
Copy link

Steps to reproduce

Choose a simple site (should all have Gutenberg 6.5 now). Confirm that the carousel option is enabled under WP Admin > Settings > Media.

  1. Add a new post
  2. Insert a Gallery Block and add images
  3. Set the "link to" setting and publish the post
  4. View the gallery on the published page

What I expected

Setting the "link to" option to "Media File" should open the images in the carousel, based on this support document:

https://en.support.wordpress.com/wordpress-editor/blocks/gallery-block/#linking

What happened instead

Setting the "link to" settings had the following results:

None = nothing opens, images not clickable
Media File = opens the individual media file
Attachment Page = mixed results. On some posts this opens the carousel, and on others I get non-clickable images.

Tested on Twenty Nineteen and on Lodestar (that was theme from the user-report)

Browser / OS version

Tested on Firefox 69.0.1 and Chrome 77.0.3865.90

Screenshot / Video - Example/Test Pages

Simple Site (free plan):
The gallery set to Attachment Pages loads the carousel
https://test1234444blog.wordpress.com/testcarousel/

Then another page on the same site set to Attachment Pages has non-clickable images
https://test1234444blog.wordpress.com/new-gallery-page/

Simple Site (free plan):
The gallery set to Attachment Pages loads the carousel here also:
https://test829463584.wordpress.com/2019/09/27/testing-gallery-blocks/

Jurassic Ninja Site w/ Gutenberg 6.5 plugin:
Gallery set to Attachment Pages has non-clickable images
https://spotty-polecat.jurassic.ninja/2019/09/27/gallery-test/

Context / Source

#user-report in #15519887-hc

@kwight kwight self-assigned this Sep 27, 2019
@kwight
Copy link
Contributor

kwight commented Sep 27, 2019

It looks like WordPress/gutenberg#17101 modified markup, that is likely important to the Jetpack carousel code. Investigating.

@mikeicode
Copy link

Ran into this on 15348312-hc also confirmed on a test site

@kwight
Copy link
Contributor

kwight commented Sep 27, 2019

Jetpack PR where carousel support was added: Automattic/jetpack#10646. This references ul markup, which is no longer used by the Gallery block as of WordPress/gutenberg#17101, so that's our culprit.

@kwight
Copy link
Contributor

kwight commented Sep 27, 2019

Jetpack fix in progress: Automattic/jetpack#13582

@brezocordero
Copy link

Also reported on 2383880-zen

@KokkieH
Copy link
Contributor

KokkieH commented Sep 29, 2019

Another report in https://en.forums.wordpress.com/topic/gallery-not-clickable/ - noting for follow-up once fixed.

@ivan-ottinger
Copy link
Contributor

Another report in #2384009-zen.

@KokkieH
Copy link
Contributor

KokkieH commented Sep 29, 2019

@joweber123
Copy link

I have a user reporting the same issue but from a Simple site using the Classic editor. I am able to reproduce the same on a test site of my own. When the carousel option is selected under layout options, the link to "Attachment page" and "Media file' both do not open to the selected option.

2387435-zen

@kriskorn
Copy link
Contributor

Another report in 2387318-zen.

@CoachBirgit
Copy link

Another report in #2386558-zen

@CoachBirgit
Copy link

Another report in #2386416-zen

@nickpagz
Copy link

Received another report in #2388326-zen

However, an additional issue that appeared on this user's site - regardless of the attachment setting, if the gallery includes only one image, the carousel will not open (image is not clickable - except for "link to media file" which opens in a new page).
Hopefully this also gets resolve in the fix.

@tijosh
Copy link

tijosh commented Sep 30, 2019

Another report of this in #14065512-hc

Followup in #2389042-zen

@tijosh
Copy link

tijosh commented Sep 30, 2019

Another report in #12697591-hc

No follow up needed

@automattic-ian
Copy link

new report in: #14942807-hc
follow up requested in: #2389144-zen

@jeherve
Copy link
Member

jeherve commented Oct 1, 2019

This should be fixed on WordPress.com already. A fix will be included in Jetpack in version 7.9, scheduled to be released in early November.

@jeherve jeherve closed this as completed Oct 1, 2019
@CoachBirgit
Copy link

another report in #2388003-zen

@kriskarkoski
Copy link
Contributor

@jeherve Would this fix be in Jetpack beta? I'm trying to brainstorm how to fix this on Atomic so they don't have to wait a month since the fix is already done, right?

@jeherve
Copy link
Member

jeherve commented Oct 3, 2019

@kriskarkoski It's in the current Bleeding Edge, yes. Here is the fix:
Automattic/jetpack#13582

@tijosh
Copy link

tijosh commented Oct 5, 2019

@jeherve Noting that with Atomic being on Gutenberg 6.6 now, this gallery carousel issue is starting to pop up in tickets for Atomic sites. Is there an ETA on when the above fix will land on Atomic sites?

@kriskarkoski
Copy link
Contributor

@tijosh It will be early-November with the next Jetpack release unless we do a point release. Details at p9F6qB-496-p2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests