Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me: Updating password unselects Password nav item #399

Closed
v18 opened this issue Nov 21, 2015 · 0 comments
Closed

Me: Updating password unselects Password nav item #399

v18 opened this issue Nov 21, 2015 · 0 comments
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Good First Issue Small, contained issues. Security [Type] Bug

Comments

@v18
Copy link
Contributor

v18 commented Nov 21, 2015

Steps to reproduce:

  1. Go to me/security (Password tab).

screen shot 2015-11-21 at 6 01 41 pm

  1. Generate or input a new password. Save it.
  2. The tab Password is now unselected.

eac79ad6-2a7a-11e5-87dd-bfff4759403b

Looks like this is due to a string comparison:

selected={ tab.path === this.props.path } in client/me/security-section-nav/index.jsx — and the path expected to mark the nav item as selected is /me/security — whereas after saving a new password is the path is actually /me/security?updated=password

@v18 v18 added [Type] Bug [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Security labels Nov 21, 2015
@lancewillett lancewillett added the Good First Issue Small, contained issues. label Dec 4, 2015
jeremeylduvall pushed a commit that referenced this issue Dec 4, 2015
- Fix for #399. When the password is updated, match this.props.path to 'me/security' so the Password menu item is highlighted.
@ebinnion ebinnion closed this as completed Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Good First Issue Small, contained issues. Security [Type] Bug
Projects
None yet
Development

No branches or pull requests

4 participants