Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JetpackManageErrorPage: Use selectors instead of computed site attributes #4160

Closed
4 tasks
ockham opened this issue Mar 18, 2016 · 0 comments · Fixed by #10573
Closed
4 tasks

JetpackManageErrorPage: Use selectors instead of computed site attributes #4160

ockham opened this issue Mar 18, 2016 · 0 comments · Fixed by #10573
Assignees
@ockham
Labels
Framework [Type] Task

Comments

@ockham
Copy link
Contributor

ockham commented Mar 18, 2016

Remove reliance on computed site attributes sourced from lib/site/index.js and lib/site/jetpack.js, instead using only values which are made available on the raw REST API site object, and use/add selectors where needed.

  • slug: Use getSiteSlug() from client/state/sites/selectors.js
  • getRemoteManagementURL(): Add selector to client/state/sites/selectors.js
  • connect() JetpackManageErrorPage to those selectors
  • Replace all other calls of getRemoteManagementURL() and remoteManagementURL, delete them from lib/site/jetpack.js.

Related issues: #2757, #4057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ockham ockham

Labels
Framework [Type] Task
Projects
None yet
Milestone
No milestone
1 participant
@ockham