Framework: redux sites contains functions

[gwwar]

The sites module in the redux state tree is not a simple object and contains references to functions. This is blocking redux state persistence in #2754

To see this, inspect reduxStore.getState().sites:

[aduth]

Likely a result of calling the receiveSite action with an object which has been processed by lib/sites-list to include additional handlers -

wp-calypso/client/my-sites/controller.js

Line 137 in 4166283

context.store.dispatch( sitesActions.receiveSite( selectedSite ) );

We should not be relying on the sites-list objects at all for the Redux state and instead store the REST API raw site response, eventually from Redux-originated action creators.

[gwwar]

We also have full moment instances on sites.plans

[rralian]

@gwwar Can we close this issue, since there are separate tasks to address this in the serialize/deserialize actions?

[gwwar]

It's slightly different. For example currently sites are persisted, but the way the data is received and stored hasn't been cleaned up.

[rralian]

I think this issue is just a flavor of sites being one of our earliest and ugliest pieces in the data layer. I think this needs to be addressed at some point as part of regular cleanup (albeit a big cleanup task), but I'm removing it from the offline iteration.

[aduth]

At the very least, we should try to whitelist attributes when receiving a site into the Redux store in the immediate future. There are conflicts in doing this, as some sections of the application are already using Redux site state and expecting it to contain the computed properties. This should be a near-term focus, as it will only become more difficult with time.

I'll see if I can slice off some time in the next week to take a closer look.