Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduxify: Notices #48408

Closed
tyxla opened this issue Dec 16, 2020 · 12 comments · Fixed by #49663
Closed

Reduxify: Notices #48408

tyxla opened this issue Dec 16, 2020 · 12 comments · Fixed by #49663
Assignees
Labels

Comments

@tyxla
Copy link
Member

tyxla commented Dec 16, 2020

This EventEmitter store is used quite a bit in Calypso (48 occurrences at this time) for managing global notices (source).

We already have a working (and quite well adopted) Redux implementation, so to get away from the EventEmitter implementation, we have to port every usage to use Redux. Those refactors are usually trivial, but it'll take some time to carry them all out.

@tyxla tyxla added [Size] M Medium sized issue [Type] Task State [Size] L Large sized issue and removed [Size] M Medium sized issue labels Dec 16, 2020
@tyxla tyxla self-assigned this Jan 5, 2021
@tyxla
Copy link
Member Author

tyxla commented Jan 5, 2021

I'm going to start working on this one.

@tyxla
Copy link
Member Author

tyxla commented Jan 5, 2021

The first two PRs, #48670 and #48671, reduxifying notices in SiteTools and password settings.

@tyxla
Copy link
Member Author

tyxla commented Jan 5, 2021

#48672 reduxifies the notice in EditContactInfoFormCard.

@tyxla
Copy link
Member Author

tyxla commented Jan 6, 2021

#48689 reduxifies notices in SEO settings.

@tyxla
Copy link
Member Author

tyxla commented Jan 14, 2021

A few more PRs here:

@tyxla
Copy link
Member Author

tyxla commented Jan 18, 2021

#49001 and #49003 to reduxify notices MultipleChoiceQuestion and PaymentMethodForm.

@tyxla
Copy link
Member Author

tyxla commented Jan 26, 2021

Several more reduxification or cleanup PRs today:

@tyxla
Copy link
Member Author

tyxla commented Feb 1, 2021

Several more PRs today to reduxify the last bits:

#49530 - Purchases: Reduxify notices in RemovePurchase
#49533 - Purchases: Reduxify notices in GSuiteCancelPurchaseDialog
#49541 - Purchases: Reduxify notices in payment method forms
#49542 - Help: Reduxify notices in HelpContact

Furthermore, #49461 takes a stab at typing the notices actions, and #49544 deprecates the old notices library.

@tyxla
Copy link
Member Author

tyxla commented Feb 2, 2021

#49600 has been open to reduxify notices in the formBase mixin, last-minute before it's actually gone. This is actually the last instance that dispatches notices the old way; once we merge all open PRs we can remove the legacy infrastructure altogether.

@tyxla
Copy link
Member Author

tyxla commented Feb 3, 2021

Final PR to remove the legacy notices store once all the above PRs are merged: #49663 🎉

@tyxla
Copy link
Member Author

tyxla commented Feb 9, 2021

All PRs have been merged, only the last one for final removal remains: #49663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant