-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purchases: Reduxify notices in payment method forms #49541
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~5 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Thanks! I'll test it out soon. The reason this may seem tricky to test is because we're in the process of removing PaymentMethodForm so I may delay on this a bit over other PRs. |
1130a89
to
cb52544
Compare
Thanks, @sirbrillig. I've rebased in the meantime. This seems to be a bit easier to review now, partially because some of the code doesn't seem to be used anywhere 😉 |
@sirbrillig what can I do to help escalate this PR? It seems to be the last one that blocks the removal of the good ol' notices library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch, @sirbrillig 🙌 |
Changes proposed in this Pull Request
This PR reduxifies notices in
PaymentMethodForm
.Note: This updates both the "add" and "update" functionality, but the "update" functionality is not in-use since this component is in the process of being removed.
Testing instructions
/purchases
. (Note: this will not work if you test/me/purchases
since that uses a different component.)Part of #48408.