Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduxify: Migrate lib/embeds #7924

Closed
4 tasks done
aduth opened this issue Sep 7, 2016 · 2 comments · Fixed by #38608
Closed
4 tasks done

Reduxify: Migrate lib/embeds #7924

aduth opened this issue Sep 7, 2016 · 2 comments · Fixed by #38608
Assignees
@tyxla
Labels
State [Type] Task
Milestone
GM Course - Redux

Comments

@aduth
Copy link
Contributor

aduth commented Sep 7, 2016 •
edited by tyxla
Loading

Related: #5046

The lib/embeds Flux store is a legacy store which uses deprecated data patterns. It should be updated to align with our current data recommendations. Specifically, this may include implementing all or some of the following Redux state behaviors:

  • Reducer
  • Action creators
  • Selectors
  • Query components

The implementation of each of these behaviors should be accompanied by tests.

When submitting a pull request, reference this issue and update the checklist above to reflect progress.
@aduth aduth added this to the GM Course - Redux milestone Sep 7, 2016
@mtias mtias mentioned this issue Sep 7, 2016
Closed
@rodrigoi rodrigoi self-assigned this Sep 16, 2016
@vindl vindl self-assigned this Sep 16, 2016
@stale
Copy link

stale bot commented Jan 11, 2018

This issue has been marked as stale because it hasn't been updated in a while. It will be closed in a week.
If you would like it to remain open, can you please you comment below and see what you can do to get things moving with this issue?
Thanks! 🙏

@stale stale bot added the [Status] Stale label Jan 11, 2018
@blowery blowery reopened this Apr 9, 2018
@stale stale bot removed the [Status] Stale label Apr 9, 2018
@blowery blowery changed the title State: Migrate lib/embeds to Redux state Reduxify: Migrate lib/embeds to Redux state Apr 9, 2018
@blowery blowery changed the title Reduxify: Migrate lib/embeds to Redux state Reduxify: Migrate lib/embeds Apr 9, 2018
@vindl vindl unassigned rodrigoi and vindl Apr 23, 2018
@tyxla tyxla self-assigned this Dec 30, 2019
@tyxla
Copy link
Member

tyxla commented Dec 30, 2019

I've been hacking on this in #38608

@tyxla tyxla mentioned this issue Dec 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tyxla tyxla

Labels
State [Type] Task
Projects
None yet
Milestone
GM Course - Redux
Development

Successfully merging a pull request may close this issue.

Framework: Reduxify embeds Automattic/wp-calypso
5 participants
@blowery @rodrigoi @vindl @aduth @tyxla