Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Redux single data tree and query components #5046

Closed
mtias opened this issue Apr 27, 2016 · 8 comments
Closed

Framework: Redux single data tree and query components #5046

mtias opened this issue Apr 27, 2016 · 8 comments
Labels
Framework Maintenance [Pri] High Address as soon as possible after BLOCKER issues [Type] Enhancement
Milestone
Offline i1: State...

Comments

@mtias
Copy link
Member

mtias commented Apr 27, 2016 •
edited by blowery
Loading

To make further progress in offline support it's imperative we consolidate our historical data approaches under the same redux state tree. Read Our Approach to Data.

Action items

In general we need to move data from Flux stores and older -list type structures into the single redux state tree. That means porting over the actions and selectors as well as creating relevant query-components.

  • Remove store module dependency.
  • Move Query components to a folder at the root of client.

Sites

Jetpack Sites

User

Posts

Stats

  • Move "stats" data to redux and remove localStorage dependency. Stats: Add stats list to redux tree #5743
  • Create post.stats state sub-tree.
    • Move Followers List ( Could we share logic with reader here ? ) to stats state sub-tree
    • Move Comments Data to stats state sub-tree
    • Move Followers Data to stats state sub-tree
    • Move Posts & Pages Data to stats state sub-tree
    • Move Countries Data to stats state sub-tree
    • Move Referrers Data to stats state sub-tree
    • Move Search Terms Data to stats state sub-tree
    • Move Clicks Data to stats state sub-tree
    • Move Authors Data to stats state sub-tree
    • Move Chart Data to stats state sub-tree
    • Move Video Data to stats state sub-tree Stats: Reduxify Video Stats Endpoint #10520

Editor (Needs Issue)

General

Reader #10984

Sharing

Themes

Plans

Domains #6144

  • Create QueryDomains component.
  • Stop using StoreConnection in domain management.
  • Remove domains flux stores.

Purchases

  • Move existing reducer in client/lib/purchases/reducer to client/state/ Purchases: Add state.purchases.items reducer #6317
  • Move existing actions in client/lib/purchases/actions to client/state/
  • Create QueryPurchases component.
  • Stop using StoreConnection in purchases.
  • Remove purchases flux stores.

Stored cards

  • Move existing reducer in client/lib/purchases/stored-cards/reducer to client/state/ Framework: Add a stored cards reducer #6413
  • Move existing actions in client/lib/purchases/stored-cards/actions to client/state/
  • Create QueryStoredCards component.
  • Stop using StoreConnection in purchases.
  • Remove stored cards flux stores.

People (Needs Issue)

Plugins #8213 #8786

SiteVouchers
@mtias mtias changed the title State: single data tree State: single data tree and query components Apr 27, 2016
@mtias mtias mentioned this issue Apr 28, 2016
Merged
@retrofox
Copy link
Contributor

retrofox commented Apr 28, 2016 •
edited by Copons
Loading

  • Move Query components to a folder at the root of client.

what about ./client/query-components/ ?

@mtias
Copy link
Member Author

mtias commented Apr 28, 2016 •
edited
Loading

Yes, that's probably the best candidate so far, though a bit long.

@mtias mtias mentioned this issue Apr 29, 2016
Merged
@roccotripaldi roccotripaldi mentioned this issue May 5, 2016
Merged
This was referenced May 9, 2016
Closed
Closed
Closed
Closed
dmsnell added a commit that referenced this issue May 9, 2016
@dmsnell
Resolves #5299
c0bbc0a 
Previously, the importer subsystem was using actions to dispatch changes
and these actions were all defined inside of `client/lib/importer`

As part of #5046 (conversion to a single global Redux tree), this commit
defines new action types inside of `client/state/action-types.js` and
converts the importer to use these globally-defined actions instead of
the locally-defined actions.

There are no visual or functional changes and this code should behave
exactly the same as before.
@dmsnell dmsnell mentioned this issue May 9, 2016
Merged
dmsnell added a commit that referenced this issue May 11, 2016
@dmsnell
Resolves #5299
617742d 
Previously, the importer subsystem was using actions to dispatch changes
and these actions were all defined inside of `client/lib/importer`

As part of #5046 (conversion to a single global Redux tree), this commit
defines new action types inside of `client/state/action-types.js` and
converts the importer to use these globally-defined actions instead of
the locally-defined actions.

There are no visual or functional changes and this code should behave
exactly the same as before.
dmsnell added a commit that referenced this issue May 12, 2016
@dmsnell
Resolves #5299
5476442 
Previously, the importer subsystem was using actions to dispatch changes
and these actions were all defined inside of `client/lib/importer`

As part of #5046 (conversion to a single global Redux tree), this commit
defines new action types inside of `client/state/action-types.js` and
converts the importer to use these globally-defined actions instead of
the locally-defined actions.

There are no visual or functional changes and this code should behave
exactly the same as before.
dmsnell added a commit that referenced this issue May 15, 2016
@dmsnell
Resolves #5299
4e0d9a0 
Previously, the importer subsystem was using actions to dispatch changes
and these actions were all defined inside of `client/lib/importer`

As part of #5046 (conversion to a single global Redux tree), this commit
defines new action types inside of `client/state/action-types.js` and
converts the importer to use these globally-defined actions instead of
the locally-defined actions.

There are no visual or functional changes and this code should behave
exactly the same as before.
This was referenced May 16, 2016
Closed
Merged
dmsnell added a commit that referenced this issue May 17, 2016
@dmsnell
Importer: Use globally-defined action types (#5304)
cdc2425 
* Resolves #5299

Previously, the importer subsystem was using actions to dispatch changes
and these actions were all defined inside of `client/lib/importer`

As part of #5046 (conversion to a single global Redux tree), this commit
defines new action types inside of `client/state/action-types.js` and
converts the importer to use these globally-defined actions instead of
the locally-defined actions.

There are no visual or functional changes and this code should behave
exactly the same as before.
roundhill pushed a commit that referenced this issue May 17, 2016
@dmsnell @roundhill
Importer: Use globally-defined action types (#5304)
b6ef128 
* Resolves #5299

Previously, the importer subsystem was using actions to dispatch changes
and these actions were all defined inside of `client/lib/importer`

As part of #5046 (conversion to a single global Redux tree), this commit
defines new action types inside of `client/state/action-types.js` and
converts the importer to use these globally-defined actions instead of
the locally-defined actions.

There are no visual or functional changes and this code should behave
exactly the same as before.
@mtias mtias mentioned this issue May 24, 2016
Merged
@timmyc
Copy link
Contributor

timmyc commented May 24, 2016

@mtias Added QueryTerms to the above, also QueryTerms should cover any need for QueryTags as well by using post_tag as the taxonomy type ( i.e. /v1.1/sites/{slug}/taxonomies/post_tag/terms )

@roccotripaldi
Copy link
Member

I added QueryUsers and QueryViewers to the People section above.

@youknowriad youknowriad mentioned this issue Dec 26, 2016
Merged
@ellatrix ellatrix mentioned this issue Dec 31, 2016
Closed
4 tasks
@youknowriad youknowriad mentioned this issue Jan 2, 2017
Merged
@ellatrix ellatrix mentioned this issue Jan 3, 2017
Merged
3 tasks
@tyxla tyxla mentioned this issue Jan 6, 2017
Merged
@youknowriad youknowriad mentioned this issue Jan 10, 2017
Closed
@mtias mtias mentioned this issue Jul 10, 2017
Merged
@lancewillett lancewillett removed the [Pri] High Address as soon as possible after BLOCKER issues label Sep 8, 2017
@ghost
Copy link

ghost commented Sep 23, 2017

@mtias : thanks for the thorough list of action items in moving everything to the redux state tree. I'm trying to get a handle on all the current outstanding or in-progress issues, and make sure we have an accurate list of the remaining tasks to get to the end goal. There are a lot of issues logged (unfortunately lots of them are old or stale).

I've created a project to consolidate all the different work happening here: https://github.com/Automattic/wp-calypso/projects/45

I'll be taking a look at the remaining action items here, and likely will split them out into their own issues so they're easier to track in the project. And I'm guessing their are action items here that are either already complete or have a duplicate issues.

Let me know if you have any concerns or comments.

@apeatling apeatling changed the title State: single data tree and query components Framework: Redux single data tree and query components Nov 15, 2017
@apeatling apeatling added [Pri] High Address as soon as possible after BLOCKER issues Maintenance and removed [Type] Task State labels Nov 15, 2017
@spen spen mentioned this issue Mar 1, 2018
Closed
@blowery
Copy link
Contributor

blowery commented Jul 18, 2018

Closing this one as we're tracking work via the project instead of this PR.

@blowery blowery closed this as completed Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Framework Maintenance [Pri] High Address as soon as possible after BLOCKER issues [Type] Enhancement
Projects
None yet
Milestone
Offline i1: State tree consolidation
Development

No branches or pull requests
9 participants
@blowery @timmyc @lancewillett @retrofox @scruffian @mtias @apeatling @roccotripaldi @rachelmcr