Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain Buttons Unresponsive in Site Editor on Mobile Browsers and Apps #87247

Closed
kelasante opened this issue Feb 6, 2024 · 7 comments
Closed
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] High Address as soon as possible after BLOCKER issues [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug

Comments

@kelasante
Copy link
Collaborator

Quick summary

Buttons that appear in the top toolbar when editing a Template in the Site Editor are not tappable. Nothing happens when you click on a specific feature like the save or style icon.

Markup 2024-02-06 at 17 39 22

Additionally, when you scroll to Patterns, and click to open a pattern, nothing happens.

Markup 2024-02-06 at 17 42 44

Steps to reproduce

  1. On a mobile app or mobile browser on a site with an FSE theme active, open the Site Editor by clicking the option to update your site's design.
  2. Go to templates
  3. Click on any of the buttons at the top of the page, like save or the block inserter
  4. Similarly, go to Patterns, and click or double-click on a pattern to open it.

What you expected to happen

To be able to access specific functionality by clicking on the button

What actually happened

Nothing happens

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

No response

Logs or notes

Able to replicate on Safari on iOS, Jetpack app and WordPress app

@kelasante kelasante added [Type] Bug Needs triage Ticket needs to be triaged [Feature] Full Site Editor The site editor. [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. labels Feb 6, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Feb 6, 2024
@kelasante
Copy link
Collaborator Author

Issue first reported in 7677675-zen

@github-actions github-actions bot added the [Pri] High Address as soon as possible after BLOCKER issues label Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 7677675-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Feb 6, 2024
@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 7, 2024

The regression appears to come from Gutenberg, the buttons become responsive again after changing the z-index for the following selector locally:

https://github.com/WordPress/gutenberg/blob/21f0fc0a813d8b4ad85a3a255e973567c9e68ce7/packages/edit-site/src/components/layout/style.scss#L38-L48

I wonder if it was introduced following the changes in WordPress/gutenberg#58077 or similar changes to fix other site editor regressions.

@SiobhyB
Copy link
Contributor

SiobhyB commented Feb 7, 2024

I was able to confirm the issue's reproducible on a self-hosted site with version 17.6.3 of the Gutenberg plugin installed. I've copied over this issue to the Gutenberg repo at WordPress/gutenberg#58781.

@Copons Copons self-assigned this Feb 7, 2024
@liviopv
Copy link

liviopv commented Feb 7, 2024

📌 REPRODUCTION RESULTS

  • Tested on Simple – Replicated
  • Tested on Atomic – Replicated
  • Replicable outside of Dotcom – Yes

📌 FINDINGS/SCREENSHOTS/VIDEO
Reproduce on a Simple Site and Atomic Site running GB 17.6.3. Deactivating GB fixes the issue.

📌 ACTIONS

  • Triaged

@liviopv liviopv added [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Feb 7, 2024
@matticbot matticbot moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Feb 7, 2024
@Copons
Copy link
Contributor

Copons commented Feb 7, 2024

I've deployed the hotfix for the top bar: #87274

Although, the patterns menu is not hotfixable as it pertains to the architecture of the Site Editor sidebar, and therefore should be fixed in Core.

Core is aware of that (of both issues, actually), so I'll leave it to you to decide whether to keep this issue open or close it. 🙂

@Copons
Copy link
Contributor

Copons commented Feb 26, 2024

This was fixed on Core as well: WordPress/gutenberg#58781

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Full Site Editor The site editor. [Feature Group] Editor Experience Features related to Gutenberg integration on WordPress.com. [Pri] High Address as soon as possible after BLOCKER issues [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Core Fix Needed A fix within the Core WordPress or Gutenberg project is required to resolve this issue. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

4 participants