Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Fix Top Bar Unclickable on Small Screens #87274

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

Copons
Copy link
Contributor

@Copons Copons commented Feb 7, 2024

Related to #87247

Proposed Changes

  • Prevent the Site Editor's WP logo from expanding to the whole width, covering the top bar, and preventing click-throughs.
Screenshot 2024-02-07 at 15 52 57

Note

This hotfix should probably live in a (new) default/editor.scss file, so that it applies to any site type.

I chose to keep it in wpcom because otherwise, AFAICS, it would need a Jetpack release to enqueue the new style.

We could do it separately if needed.

Testing Instructions

  • Sync these changes to the sandbox.
  • Sandbox a test site and widgets.wp.com.
  • Open the site editor and enter canvas mode (/wp-admin/site-editor.php?canvas=edit).
  • Ensure the top bar is all clickable.
  • Resize the window to a phone-like width.
  • Ensure the top bar is all clickable.
  • Ensure the WP logo is clickable too.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-ajp-p2)?

@Copons Copons requested a review from a team February 7, 2024 15:58
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2024
@Copons Copons self-assigned this Feb 7, 2024
@Copons Copons added [Feature] Full Site Editor The site editor. and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Feb 7, 2024
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@rcrdortiz rcrdortiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described. Can we create a follow-up task for releasing this change on Jetpack too?

@Copons Copons merged commit 44eec44 into trunk Feb 7, 2024
13 of 15 checks passed
@Copons Copons deleted the fix/site-editor-wp-logo-covering-top-bar branch February 7, 2024 16:13
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 7, 2024
@fullofcaffeine
Copy link
Contributor

Thanks for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants