-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack Settings: Add Theme Enhancements card under Writing Settings for Jetpack sites #10083
Conversation
b67c60b
to
2b944d9
Compare
Can we get a screenshot/mock of what we should be seeing for this? |
c3a1773
to
6dd156c
Compare
Sure thing, I've updated the PR description to contain a screenshot. I'll also update with some testing instructions and additional information once the PR is ready to review.
Yeah, this was in progress, but I've now updated it, too. Could have missed it, so good catch! 👍 |
b39f180
to
165e2dc
Compare
This PR works and saves data properly; however it will be best if we adapt it to using the bulk settings endpoint; this is being implemented in #10123. |
165e2dc
to
783d7fb
Compare
I've adapted this PR to use bulk settings from #10123, and done a ton of other improvements. I've also updated the PR description with new screenshots, and a TODO list with the remaining stuff. |
d20ad50
to
315c158
Compare
87e0b5c
to
af70a7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. Everything works smoothly, and as described, even when switching between sites.
78b942b
to
4b138de
Compare
Introduction
This PR is part of #9171. It introduces a Theme Enhancements card under Writing Settings. This card will be used to manage the settings of the Infinite Scroll and Mobile Theme Jetpack modules.
Preview
Both modules activated, some settings are disabled
Initial loading
Loading while saving
Disabled modules (settings are hidden)
Testing
/settings/writing/$site
, where$site
is the slug of your Jetpack site.