Framework: Upgrade ESLint comma-spacing to error #11427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copons
added
Framework
[Status] Needs Review
|
Rebased locally and tested branch successfully, LGTM 👍 Probably want to rebase / push once more to let CircleCI confirm, but otherwise should be fine to merge. |
aduth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Copons
force-pushed
the
update/eslint/comma-spacing
branch
from
b303a19 to
e891cf3
Compare
Copons
force-pushed
the
update/eslint/comma-spacing
branch
from
e891cf3 to
744142a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #8562
This pull request continues the crusade to upgrade all ESLint rules to errors by resolving remaining issues with
comma-spacingrule.Testing Instructions:
That CircleCI passes is indication that the changes included are working as intended.
Verify that no regressions have been introduced to affected sections.