Media section: Move Action buttons to top, multiple selection #11589

artpi · 2017-02-24T11:17:17Z

This PR resolves #11512, #10851 and puts some work towards #10805

Enables selecting of multiple media items
Moves secondary action buttons to top action bar where they can be redesigned
Splits off following tasks:

The bar does not look how it should, continue in #10805 to make it look proper

Show me

CC @iamtakashi @rralian @retrofox @gwwar @lamosty

matticbot · 2017-02-24T11:17:18Z

Test live: https://calypso.live/?branch=media-section/action-bar-edit-buttons

retrofox · 2017-02-24T13:15:17Z

Is the idea apply these changes also in the media-modal?

Anyway, we should one of them in the media-modal.

retrofox · 2017-02-24T13:21:07Z

client/my-sites/media-library/header.jsx

+					renderStorage={ false }
+					site={ this.props.site }
+					view={ 'LIST' }
+				/>


A trivial detail, but sometimes you're closing the component instance on a new line and sometimes not.

retrofox · 2017-02-24T13:22:16Z

client/my-sites/media/main.jsx

@@ -28,7 +31,8 @@ export default React.createClass( {
 	getInitialState: function() {
 		return {
 			editedItem: null,
-			openedDetails: null,
+			currentDetail: null,
+			selectedImages: []


trailing comma missed.

done a68b222

retrofox · 2017-02-24T13:24:44Z

client/my-sites/media/main.jsx

-	openDetailsModal( item ) {
-		this.setState( { openedDetails: item } );
+	openDetailsModalForASingleImage( image ) {
+		const selected = [ image ];


I think that not much is gained by creating a constant here.

this.setState( { currentDetail: 0, selectedImages: [ image ] } );

done a68b222

artpi · 2017-02-24T13:42:15Z

Is the idea apply these changes also in the media-modal?

Yes, as in #10805

gwwar · 2017-02-24T19:25:52Z

Since this is difficult to make small changes here without breaking the flow in editor, let's target try/media-section-v2 instead of master. We'll try to scope that feature branch to just the action bar changes and plan storage modifications. Ideally this feature branch should not live longer than a week or so.

gwwar

Thanks @artpi this looks like a good first step. Smoke tested functionality in both the modal and the section and things look good. We should be ok to land in the shared branch.

I did notice some small behavior differences that we can address in follow ups:

In the media section select a number of items, click edit, page to some position other than the first item. Click "<- Media Library". Click Edit again. We start at position 0. (The media modal in the post editor remembers which item you had open).
Navigate to the post editor. Open up the Media Modal. We see the selection from the media section.

@iamtakashi Did you intend for the detail/edit pages to be a modal in the media section? Or did we want those pieces to be inline? If it's the latter ping me and we can create more issues.

iamtakashi · 2017-02-27T16:19:41Z

@iamtakashi Did you intend for the detail/edit pages to be a modal in the media section?

Yes. I think it should be the same as editing images from the modal.

gwwar · 2017-02-27T16:34:24Z

Yes. I think it should be the same as editing images from the modal.

@iamtakashi To clarify the image editor will be a modal atm, but did we intend for things like the image title/details/url etc to be editable inline on a page view for the media section.

artpi · 2017-02-27T17:34:43Z

In the media section select a number of items, click edit, page to some position other than the first item. Click "<- Media Library". Click Edit again. We start at position 0. (The media modal in the post editor remembers which item you had open).

That should be resolved in #11592

iamtakashi · 2017-02-27T22:21:27Z

@gwwar I didn't consider inline editing like that at this moment. I can see the idea could work, but we'll have many questions to make it happen. I'll keep that mind!

gwwar · 2017-02-27T22:35:32Z

Thanks @iamtakashi 👍

* Make multiple selection work + admin bar * Fix single image edit * Mae bulk delete work * Reuse MediaModalSecondaryActions * Review fixes

matticbot · 2017-03-29T02:45:35Z

@artpi This PR needs a rebase

artpi added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 24, 2017

artpi self-assigned this Feb 24, 2017

matticbot added the [Size] L Large sized issue label Feb 24, 2017

artpi mentioned this pull request Feb 24, 2017

Media section: Action bar buttons + card #11560

Merged

retrofox reviewed Feb 24, 2017

View reviewed changes

artpi mentioned this pull request Feb 24, 2017

Media section: abstract away post-editor/media-modal and my-sites/media/main #11592

Closed

gwwar requested review from iamtakashi and gwwar February 24, 2017 18:17

gwwar changed the base branch from master to try/media-section-v2 February 24, 2017 19:40

gwwar approved these changes Feb 24, 2017

View reviewed changes

artpi added 4 commits February 28, 2017 10:04

Make multiple selection work + admin bar

9ded9a6

Fix single image edit

6803475

Mae bulk delete work

6857681

Reuse MediaModalSecondaryActions

1796d15

artpi force-pushed the media-section/action-bar-edit-buttons branch from 1dd45d5 to 1796d15 Compare February 28, 2017 09:10

matticbot added the [Size] L Large sized issue label Feb 28, 2017

Review fixes

a68b222

artpi merged this pull request into try/media-section-v2 Feb 28, 2017

artpi deleted the media-section/action-bar-edit-buttons branch February 28, 2017 09:23

matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 28, 2017

artpi added a commit that referenced this pull request Mar 1, 2017

Media section: Move Action buttons to top, multiple selection (#11589)

070ffcd

* Make multiple selection work + admin bar * Fix single image edit * Mae bulk delete work * Reuse MediaModalSecondaryActions * Review fixes

artpi mentioned this pull request Mar 3, 2017

Media: Add Storage nudge #11667

Closed

4 tasks

artpi added a commit that referenced this pull request Mar 6, 2017

Media section: Move Action buttons to top, multiple selection (#11589)

1010194

* Make multiple selection work + admin bar * Fix single image edit * Mae bulk delete work * Reuse MediaModalSecondaryActions * Review fixes

retrofox pushed a commit that referenced this pull request Mar 8, 2017

Media section: Move Action buttons to top, multiple selection (#11589)

db8c663

* Make multiple selection work + admin bar * Fix single image edit * Mae bulk delete work * Reuse MediaModalSecondaryActions * Review fixes

retrofox pushed a commit that referenced this pull request Mar 8, 2017

Media section: Move Action buttons to top, multiple selection (#11589)

7921b53

* Make multiple selection work + admin bar * Fix single image edit * Mae bulk delete work * Reuse MediaModalSecondaryActions * Review fixes

retrofox pushed a commit that referenced this pull request Mar 9, 2017

Media section: Move Action buttons to top, multiple selection (#11589)

c7371ad

* Make multiple selection work + admin bar * Fix single image edit * Mae bulk delete work * Reuse MediaModalSecondaryActions * Review fixes

retrofox added the [Feature] Media The media screen in Calypso, general media management, or integration with third party media. label Mar 9, 2017

retrofox mentioned this pull request Mar 9, 2017

Media: add media section #11822

Merged

retrofox pushed a commit that referenced this pull request Mar 9, 2017

Media section: Move Action buttons to top, multiple selection (#11589)

75aebee

* Make multiple selection work + admin bar * Fix single image edit * Mae bulk delete work * Reuse MediaModalSecondaryActions * Review fixes

retrofox pushed a commit that referenced this pull request Mar 10, 2017

Media section: Move Action buttons to top, multiple selection (#11589)

dcf03b6

* Make multiple selection work + admin bar * Fix single image edit * Mae bulk delete work * Reuse MediaModalSecondaryActions * Review fixes

matticbot added the [Status] Needs Rebase label Mar 29, 2017

jsnajdr mentioned this pull request Mar 29, 2021

Simplify the MediaModalSecondaryActions component #51495

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Media section: Move Action buttons to top, multiple selection #11589

Media section: Move Action buttons to top, multiple selection #11589

artpi commented Feb 24, 2017 •

edited

Loading

matticbot commented Feb 24, 2017

retrofox commented Feb 24, 2017

retrofox Feb 24, 2017

retrofox Feb 24, 2017

artpi Feb 28, 2017

retrofox Feb 24, 2017 •

edited

Loading

artpi Feb 28, 2017

artpi commented Feb 24, 2017

gwwar commented Feb 24, 2017

gwwar left a comment

iamtakashi commented Feb 27, 2017

gwwar commented Feb 27, 2017

artpi commented Feb 27, 2017

iamtakashi commented Feb 27, 2017

gwwar commented Feb 27, 2017

matticbot commented Mar 29, 2017

Media section: Move Action buttons to top, multiple selection #11589

Media section: Move Action buttons to top, multiple selection #11589

Conversation

artpi commented Feb 24, 2017 • edited Loading

Show me

matticbot commented Feb 24, 2017

retrofox commented Feb 24, 2017

retrofox Feb 24, 2017

Choose a reason for hiding this comment

retrofox Feb 24, 2017

Choose a reason for hiding this comment

artpi Feb 28, 2017

Choose a reason for hiding this comment

retrofox Feb 24, 2017 • edited Loading

Choose a reason for hiding this comment

artpi Feb 28, 2017

Choose a reason for hiding this comment

artpi commented Feb 24, 2017

gwwar commented Feb 24, 2017

gwwar left a comment

Choose a reason for hiding this comment

iamtakashi commented Feb 27, 2017

gwwar commented Feb 27, 2017

artpi commented Feb 27, 2017

iamtakashi commented Feb 27, 2017

gwwar commented Feb 27, 2017

matticbot commented Mar 29, 2017

artpi commented Feb 24, 2017 •

edited

Loading

retrofox Feb 24, 2017 •

edited

Loading