Plans: Fixes logic issue for when we were showing the confirmation notice #11693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebinnion
added
[Feature] Plans & Upgrades
gwwar
approved these changes
Mar 2, 2017
There was a problem hiding this comment.
LGTM 
Next time in the summary you can add testing instructions to create a new user and follow nux, or modify https://github.com/Automattic/wp-calypso/blob/master/client/my-sites/upgrades/checkout-thank-you/index.jsx#L209 and visit http://calypso.localhost:3000/checkout/thank-you/:siteId:/:receiptId: of an earlier purchase.
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier this afternoon, I noticed an issue where I was improperly seeing this notice above the plans thank you card.
The issue seems to be that the code expected
email_verifiedto be passed in as a prop, but it is really part ofthis.props.user. This PR fixes that.To test:
Currently, the PlansThankYouCard only shows for new WP.com users, so this is not the easiest thing to test. But, you could checkout #11692 and then apply this fix on top of that PR to test.