Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: reimplement plan-storage structure using flexbox #11769

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

retrofox
Copy link
Contributor

@retrofox retrofox commented Mar 4, 2017

IMPORTANT

This PR is part of a set of PRs. Take a look to #11667, Pull requests section, to know to right order to review.

This PR is targeting to try/media-section-v2.


This simple PR reimplements plan-storage using flexbox pattern.

@matticbot matticbot added the [Size] S Small sized issue label Mar 4, 2017
@matticbot
Copy link
Contributor

@artpi artpi mentioned this pull request Mar 4, 2017
4 tasks
@retrofox retrofox requested review from iamtakashi and gwwar March 4, 2017 14:03
@retrofox retrofox added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Enhancement labels Mar 4, 2017
@artpi artpi force-pushed the try/media-section-v2 branch from 7791f0f to a343b88 Compare March 6, 2017 16:37
@retrofox retrofox force-pushed the update/plan-storage branch from 1bb5cc2 to e41abcd Compare March 6, 2017 18:36
@matticbot matticbot added the [Size] S Small sized issue label Mar 6, 2017
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @retrofox Looks like this behaves pretty well 👍

}

.plan-storage__storage-link {
float: right;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gwwar gwwar added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 6, 2017
@retrofox retrofox merged commit 5e173aa into try/media-section-v2 Mar 6, 2017
@retrofox retrofox deleted the update/plan-storage branch March 6, 2017 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants