Site Settings: Disable Photon when in Dev mode

[tyxla]

This PR will disable the Photon if the current Jetpack site is in development mode. Related with #11386.

Preview when Photon is disabled because of Dev mode:

To test:

• Checkout this branch
• Select one of your Jetpack sites and enable dev mode by adding this to your wp-config.php: define( 'JETPACK_DEV_DEBUG', true );
• Verify the Photon toggle in the Media card in the Writing tab is disabled.
• Disable the Dev mode by deleting the line we just added to wp-config.php.
• Verify the Photon toggle is now enabled and can be interacted with.

/cc @rickybanister @MichaelArestad because I have the feeling that we need do something more in addition to just disabling the toggle in that case (as also mentioned here: #11386 (comment)).

[matticbot]

Test live: https://calypso.live/?branch=update/jetpack-settings-photon-devmode

[MichaelArestad]

LGTM.

[roccotripaldi]

LGTM!

[tyxla]

Holding this one until we merge #11386

[rickybanister]

Quick question about this one—since Photon is a dependency for slideshows, shouldn't slideshows also be disabled when photon is off due to dev mode?

[tyxla]

Photon is a dependency for slideshows

AFAIK Photon is not a dependency for Carousel, unless I'm missing something?

[MichaelArestad]

I thought it was only a dependency for Tiled Galleries. @beaulebens can you clarify?

[beaulebens]

I just tested this with Photon turned off, and;

• Tile Galleries worked fine for me! (tried mosaic and circles)
• Slideshow worked fine
• Carousel worked fine

So, now I don't know where the expectation came from that Photon is required to use other things, but it doesn't appear to be accurate.

[MichaelArestad]

@beaulebens hmmm. I know tiled galleries requires it. Maybe it turns it on just for the galleries? Can you check?

If so, I can just remove the Tiled Galleries comment.

[beaulebens]

I take that back -- Photon gets used regardless on both Carousel and Tiled Galleries, even if Photon is turned off.