Build: Async Load Happy Chat, CSS Reload, Network detection (take 2) #11868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blowery
added
Build
[Status] Needs Review
blowery
force-pushed
the
revert/revert/async-load-happy-chat
branch
from
72e6baa to
6241acb
Compare
This reverts commit 1008869.
blowery
force-pushed
the
revert/revert/async-load-happy-chat
branch
from
6241acb to
9d09ec7
Compare
|
Seems to be working properly 👍 Can I have some background info on the reason it was reverted? |
Tug
added
[Status] Needs Author Reply
and removed
[Status] Needs Review
Splitting the bundle also ends up duplicating the flux store that backs HappyChat. I had thought that this duplication led to two instances of the flux store being active at the same time, but that fear turned out to be incorrect. Webpack registers modules by ID and the first one registered wins. Any subsequent module with the same ID is just ignored. |
blowery
added
[Status] Needs Review
gziolo
added
[Status] Ready to Merge
and removed
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1008869.
A retry of #11714
Shaves 25kb off the gzip'd build bundle (424kb ➡️ 399kb). Needs more testing to verify it 1) works as expected and 2) uses a reasonable placeholder for the chat box while loading.
Most of the reason for the size diff here is that happy-chat is the only thing in boot using socket.io, which is a pretty big package itself, even after gzip. Necessary, but large.