Editor: Fix footer styling issues #12078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmyc
force-pushed
the
fix/editor/firefox-height
branch
from
7da01bb to
789a363
Compare
timmyc
added
[Feature] Post/Page Editor
mtias
reviewed
Mar 14, 2017
| @@ -9,11 +9,33 @@ | |||
| @include breakpoint( "<660px" ) { | |||
| margin-bottom: 8px; | |||
| } | |||
| } | |||
|
|
|||
| .editor-status-label.editor-action-bar__saved-status { | |||
There was a problem hiding this comment.
Can't you target this with .editor-action-bar .editor-status-label instead of creating a new class?
|
Nice, much simpler. |
mtias
added
[Status] Ready to Merge
and removed
[Status] Needs Review
timmyc
force-pushed
the
fix/editor/firefox-height
branch
from
daeee4b to
c3cd387
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #11536 - which moved the "saved ago in words" notice to the footer area of the editor. When viewing the editor in smaller viewports, this text was being hidden behind the editor:
After
In this branch I've opted to style the saved ago text identical to the word count component which is also shown in the footer, and as a result, a transparent footer is created in smaller viewports, much like the transparent toolbar at the top of the editor:
The transparent effect only happens in smaller viewports or when the sidebar is toggled on, due to the flexbox treatment on the actionbar. I'm wondering if we should just remove this text from the
<ActionBar />and create a new editor footer component that houses the saved ago and word counts.I have also hidden the saved ago text on
<480viewports entirely.