-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reader: Fix full post view closing when any click on popover menu #1208
Conversation
Full post view is wrapped by dialog and any click on popover menu fires clickOutside event that closes the full post view. It's because popover view is attached on body tag. To fix it, prevent default action of click outside event for full post view.
Hi @dongseok0, thanks for the PR! Works great, but I noticed that it exposes a new problem. If you view a post from a blog you own in the reader, an Edit Post action appears. If you pick that action from the menu, we move over to the editor, but the Full Post Dialog doesn't close. It appears we can just add an exit route handler:
Could you add that to the PR? Should be good to go. |
Add exit route handler to close FullPostDialog
Added exit route handlers! 😄 |
Reader: Fix full post view closing when any click on popover menu
Full post view is wrapped by dialog and any click on popover menu
fires clickOutside event that closes the full post view. It's because
popover view is attached on body tag.
To fix it, prevent default action of click outside event for full post view.
#686