Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: display email verification notice in the header area. #12107

Merged
merged 3 commits into from
Mar 14, 2017
Merged

Editor: display email verification notice in the header area. #12107

merged 3 commits into from
Mar 14, 2017

Conversation

mtias
Copy link
Member

@mtias mtias commented Mar 14, 2017

Fixes broken layout.

image

@mtias mtias added [Feature] Post/Page Editor The editor for editing posts and pages. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 14, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/editor-email-verification-notice

@matticbot matticbot added the [Size] M Medium sized issue label Mar 14, 2017
@jasmussen
Email verification notice: try floating popup.
12b0d24 
The problem with the other one was that it wasn't very scalable from a responsive point of view. Considering German is usually 20% longer, it just wasn't a safe bet.

By making it floating, yes, we cover the sidebar, but since you can't publish regardless, perhaps that's okay.
@jasmussen
Copy link
Member

Some screenshots of the latest change:

screen shot 2017-03-14 at 12 20 08

screen shot 2017-03-14 at 12 20 13

screen shot 2017-03-14 at 12 20 22

@mtias mtias merged commit 832ef33 into master Mar 14, 2017
@mtias mtias deleted the fix/editor-email-verification-notice branch March 14, 2017 11:45
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 14, 2017
@snyk-bot snyk-bot mentioned this pull request May 30, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Oct 25, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Nov 4, 2021
Open
@ajesse11x ajesse11x mentioned this pull request Oct 20, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Nov 16, 2023
Open
@ajesse11x ajesse11x mentioned this pull request Mar 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jasmussen jasmussen

Labels
[Feature] Post/Page Editor The editor for editing posts and pages. [Size] M Medium sized issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtias @matticbot @jasmussen