Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaLibrary - set minimun limito to sticky the header panel #12117

Merged
merged 2 commits into from
Mar 14, 2017

Conversation

retrofox
Copy link
Contributor

This PR fixes #12076 allowing define a minimum limit to force to do not stick the <StickyPanel /> component beyond of the isMobile conditions.

Testing

Open a media library sections with a lot of images trying to scroll up the section with a viewport width less or equal to 660px. The header shouldn't be sticked.

before this patch

after this patch

@retrofox retrofox added [Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Mar 14, 2017
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Size] S Small sized issue label Mar 14, 2017
@retrofox retrofox requested review from jhnstn, iamtakashi and gwwar March 14, 2017 15:24
Copy link
Contributor

@gwwar gwwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@retrofox LTGM. I smoke tested the theme and stats usages and verified that we no longer try to sticky on mobile views for the media section. We can revisit this component in future PRs to find a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media The media screen in Calypso, general media management, or integration with third party media. [Size] S Small sized issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media Section: Fix sticky nav styling for smaller viewports
3 participants