Themes: Drop sites-list usage (take two) #12124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Feature Group] Appearance & Themes
ockham
force-pushed
the
remove/themes-sites-list-dep-take-two
branch
2 times, most recently
from
6293a3c to
c68c43b
Compare
ockham
force-pushed
the
remove/themes-sites-list-dep-take-two
branch
from
c68c43b to
deefa68
Compare
ockham
force-pushed
the
remove/themes-sites-list-dep-take-two
branch
2 times, most recently
from
9a8b9bd to
5cd2af4
Compare
ockham
force-pushed
the
remove/themes-sites-list-dep-take-two
branch
from
5cd2af4 to
8b49f37
Compare
76 tasks
ockham
commented
Mar 15, 2017
| @@ -38,7 +38,6 @@ JetpackSite.prototype.updateComputedAttributes = function() { | |||
| this.canUpdateFiles = SiteUtils.canUpdateFiles( this ); | |||
| this.canAutoupdateFiles = SiteUtils.canAutoupdateFiles( this ); | |||
| this.hasJetpackMenus = versionCompare( this.options.jetpack_version, '3.5-alpha' ) >= 0; | |||
| this.hasJetpackThemes = versionCompare( this.options.jetpack_version, '3.7-beta' ) >= 0; | |||
There was a problem hiding this comment.
This is obsolete, site.hasJetpackThemes isn't used anywhere anymore. (Try grepping for hasJetpackThemes.)
ockham
commented
Mar 15, 2017
| isJetpack: isJetpackSite( state, selectedSiteId ), | ||
| isCustomizable: canCurrentUser( state, selectedSiteId, 'edit_theme_options' ), |
There was a problem hiding this comment.
This is obsolete -- try grepping for isCustomizable .
ockham
commented
Mar 15, 2017
| filter, | ||
| vertical | ||
| vertical, | ||
| wpcomTier | ||
| } = props; | ||
| const jetpackEnabled = config.isEnabled( 'manage/themes-jetpack' ); | ||
|
|
||
| if ( ! jetpackEnabled ) { | ||
| return ( | ||
| <JetpackReferrerMessage |
There was a problem hiding this comment.
We'll be able to drop this component altogether once we drop the (now obsolete) manage/themes-jetpack feature flag.
ockham
added
[Status] Needs Review
|
Tested on Chrome:
I didn't test: mange disabled (how?), outdated version, multi-site install. Aside: the order of the ••• menu items between Jetpack and .com sites is different, we should fix that in a later PR. |
folletto
approved these changes
Mar 16, 2017
Tested those myself. Will merge now. |
matticbot
removed
the
[Status] Needs Review
matticbot
added
[Size] M
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This affects only single-site mode, and mostly Jetpack error/warning messages (JP upgrade needed/JP Manage disabled/etc) there.
To test:
wp-admintheme showcase) forOpen WP Adminbutton points correctly towp-admin.Deprecates #8776, which was quite outdated.
(We're still passing around a bunch of props rather needlessly or at least inelegantly, but I'll leave those for a future PR.)