Fix Safari-specific sidebar height issue on mobile. #12318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari has a flex-box bug detailed here: https://github.com/philipwalton/flexbugs#1-minimum-content-sizing-of-flex-items-not-honored This bug affected the Post Settings sidebar when opened on mobile breakpoints. This commit fixes it, and fixes #12212.
jasmussen
added
[Feature] Post/Page Editor
youknowriad
approved these changes
Mar 20, 2017
There was a problem hiding this comment.
LGTM 👍 The broken behaviour (no-scrolls and hidden sections) seen on master is fixed here.
Also, while testing I noticed a small issue on a breakpoint slightly bigger than mobile where the title of the post is shown above the Post Settings sidebar at the bottom of the page. Should I create an issue for this?
No, this is something I hope to look at next. Thanks a bunch. |
matticbot
removed
the
[Status] Needs Review
jhnstn
pushed a commit
that referenced
this pull request
Mar 21, 2017
Safari has a flex-box bug detailed here: https://github.com/philipwalton/flexbugs#1-minimum-content-sizing-of-flex-items-not-honored This bug affected the Post Settings sidebar when opened on mobile breakpoints. This commit fixes it, and fixes #12212.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari has a flex-box bug detailed here: https://github.com/philipwalton/flexbugs#1-minimum-content-sizing-of-flex-items-not-honored
This bug affected the Post Settings sidebar when opened on mobile breakpoints. This commit fixes it, and fixes #12212.