People: Invites: Disable buttons on accept #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From a UX perspective I like that we're now showing the user that something is in progress. However, when I tried to accept an invite while logged in, I was never redirected away from the invite accept page:
When I checked out |
| <Button primary onClick={ () => acceptInvite( this.props.invite ) } href={ this.props.redirectTo } > | ||
| { this.translate( 'Join', { context: 'button' } ) } | ||
| <Button primary onClick={ this.accept } disabled={ this.state.submitting }> | ||
| { this.state.submitting ? this.translate( 'Joining…', { context: 'button' } ) : this.translate( 'Join', { context: 'button' } ) } |
There was a problem hiding this comment.
Maybe we could make this a shorter line by rewriting as:
{
this.state.submitting
? this.translate( 'Joining…', { context: 'button' } )
: this.translate( 'Join', { context: 'button' } )
}
|
LGTM. |
lezama
added a commit
that referenced
this pull request
Dec 3, 2015
…ns-after-accept People: Invites: Disable buttons on accept
This was referenced Nov 18, 2020
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1197
cc @ebinnion @roccotripaldi for an early review