Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domains: Standardize store and module getters #1254

Merged
merged 3 commits into from
Dec 8, 2015

Conversation

stephanethomas
Copy link
Contributor

This pull request seeks to standardize the few access methods that weren't following the de facto naming convention in Flux stores (used in the domains management section) as well as in a module (used in the checkout). The logic didn't change and everything should work as before.

Testing instructions

Checkout
  1. Navigate to the Domains Search page
  2. Click on any Add button to add a domain to the shopping cart
  3. Click on the No thanks, I don't need email or will use another provider. link on the next page
  4. Select a country on the Domain Registration Details page that triggers the list of states (e.g. Spain)
  5. Fill in and submit the form
  6. Submit the form on the Secure Payment page and check that the purchase was successful
Domains Management
  1. Navigate to the Domains page
  2. Click on the new domain registration to open the corresponding Domain Settings page
  3. Check that you can still perform any operation such as:
    • Making the domain primary
    • Adding an email forward
    • Adding a DNS record
    • Updating name servers

@stephanethomas stephanethomas added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Dec 3, 2015
@stephanethomas stephanethomas self-assigned this Dec 3, 2015
@stephanethomas stephanethomas added the [Feature] Checkout The checkout screen and process for purchases made on WordPress.com. label Dec 3, 2015
@stephanethomas stephanethomas force-pushed the fix/store-and-module-getters branch from ecda755 to c088ca9 Compare December 5, 2015 19:20
@gziolo gziolo added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 7, 2015
@gziolo
Copy link
Member

gziolo commented Dec 7, 2015

Code changes look good and app works like before 👍

gziolo added a commit that referenced this pull request Dec 8, 2015
Domains: Standardize store and module getters
@gziolo gziolo merged commit 723cb42 into master Dec 8, 2015
@gziolo gziolo deleted the fix/store-and-module-getters branch December 8, 2015 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Checkout The checkout screen and process for purchases made on WordPress.com. [Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants