Notices: Make action buttons appear in global notices again #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some refactoring of the global notices caused action buttons to disappear. This adds the new `ActionButton` component to `NoticeList` when a `button` property is set in the options for a notice.
jordwest
added
the
[Status] Needs Review
|
Works great and updates the buttons to the new style:
LGTM! |
johnHackworth
added
[Status] Ready to Merge
and removed
[Status] Needs Review
|
This also fixes the regression I found in plugins. Before: After: Thanks for fixing it! |
jordwest
added a commit
that referenced
this pull request
Dec 4, 2015
…tons Notices: Make action buttons appear in global notices again
This was referenced May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring of the global notices caused action buttons to disappear. This adds the new
NoticeActioncomponent toNoticesListwhen abuttonproperty is set in the options for a notice.