Framework: Allow debug everywhere

[samouri]

Stop replacing debug with debug-noop in in production.

Thinking:

1. its helpful to be able to look at debug statements in every environment
2. debug is a tiny library that doesn't add much to our bundle size
3. debug wont' hurt performance in any way for those uninterested since it is opt-in via localStorage anway.

To Test:

• debug statements should still work in development
• debug statements should now work in docker

[matticbot]

Test live: https://calypso.live/?branch=update/framework/debug-runtime-check

[blowery]

maybe just use lodash/noop or a single noop function to cut down on the number of functions we create?

[aduth]

The default cache key implementation for createSelector could serve as reference for how to optimize module loading via Webpack dead code detection to avoid importing the debug module:

https://github.com/Automattic/wp-calypso/blob/b5b487b/client/lib/create-selector/index.js#L38-L61

[samouri]

@aduth, that only works for differentiating between docker vs. dev server.
Since launching #11352, anything that is marked with if ( 'production' !== process.env.NODE_ENV ) will be removed from both wpcalypso and staging as well as production.

With these constraints, my current thought is that it could be best to use the regular debug in all environments

[aaronyan]

I believe this PR would fix #12277

[samouri]

I just tested locally + in docker. both w4m

[samouri]

I tested out the difference in bundle size. The vendor chunk grew from 672K --> 676K.
Everything else remained equivalent

[dmsnell]

Seems fair to me. I would like some cake for this review.

[dmsnell]

The vendor chunk grew from 672K --> 676K.
Everything else remained equivalent

this suggests to me that we made a poor replacement: we were almost certainly leaving in the strings which were the largest part of debug() 🤦‍♂️

I wonder what would happen to the size if we not only removed debug() but also removed anything that chains on a call to debug. for instance, use a Babel transform to remove all code which depend on debug; not only replace it with a noop, but actually pull out the function calls

[samouri]

@dmsnell: yep! That would make a much larger difference for build size

Just did a quick check and it looks like we have something on the order of 1.5 thousand debug calls across calypso. When i grepped all the lines and zipped them it was ~ 25Kb.

[samouri]

Thanks for the review @dmsnell! I'll merge this in tomorrow afternoon unless there are objections that come up.

[dmsnell]

Just did a quick check and it looks like we have something on the order of 1.5 thousand debug calls across calypso. When i grepped all the lines and zipped them it was ~ 25Kb.

when I asked about the build size difference this is about what I expected to find. that could also easily cut down our build size. now I'm wondering why we ever disabled debug because it wasn't helping us on size. we should have done it for realz and gotten that 25 KB