Selectors: Add areAllSitesSingleUser #13123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
ockham
force-pushed
the
add/selectors/are-all-sites-single-user
branch
from
bcd72ba to
8f81602
Compare
matticbot
added
[Size] M
ockham
added
[Status] Needs Review
gwwar
reviewed
Apr 14, 2017
| * @param {Object} state Global state tree | ||
| * @return {Boolean} True if all sites are single user sites | ||
| */ | ||
| export default function areAllSitesSingleUser( state ) { |
There was a problem hiding this comment.
Might be worth memoizing with createSelector
gwwar
reviewed
Apr 14, 2017
| */ | ||
| export default function areAllSitesSingleUser( state ) { | ||
| const siteIds = Object.keys( state.sites.items ); | ||
| return siteIds && siteIds.every( ( siteId ) => isSingleUserSite( state, siteId ) ); |
There was a problem hiding this comment.
I believe an empty array will be true here
gwwar
approved these changes
Apr 14, 2017
|
AFAICS, this is only used by the post editor to route to |
ockham
force-pushed
the
add/selectors/are-all-sites-single-user
branch
from
61d8aa8 to
2e7f87a
Compare
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returns true if every site of the current user is a single user site.
Needed for #13121 and #13094.
Not used in code yet.