Notices: Fix whitespace in global notices #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty Notices list was pushing content of every view This reverts commit ff90769.
|
👍 |
|
This PR fixes the relevant part of the problem with the searchbar at |
artpi
added a commit
that referenced
this pull request
Dec 7, 2015
Notices: Fix whitespace in global notices (ff90769 revert)
This was referenced May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty Notices list was pushing content of every view
This reverts commit ff90769.
Why?
Commit ff90769 introduced NoticeList in every page.
This became a problem because notice list scrolls with the content.
Testing