Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Themes: sheet on mobile had screenshot covering CTA bug #13598

Merged
merged 1 commit into from
May 3, 2017
Merged

Themes: sheet on mobile had screenshot covering CTA bug #13598

merged 1 commit into from
May 3, 2017

Conversation

folletto
Copy link
Contributor

@folletto folletto commented May 3, 2017

Bug: the screenshot is covering the header and call to action on the theme sheet page on mobile.

Also, fix: "Open Live Demo" button position more reliable.

Current (bug):

screen shot 2017-05-03 at 14 44 38

This PR:

screen shot 2017-05-03 at 14 45 48

To test

  1. Open any theme page on Calypso, on mobile
  2. Check the header with the name and the CTA button is visible
  3. Try to activate the theme
  4. Try to navigate back to the full list

/ht @fditrapani for the bug discovery

@folletto
Themes: sheet on mobile had screenshot covering CTA
5d8b576 
Fix: "Open Live Demo" button position more reliable
@folletto folletto added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Bug labels May 3, 2017
@folletto folletto added this to the Themes: Showcase M6-TheOne milestone May 3, 2017
@folletto folletto self-assigned this May 3, 2017
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=fix/themes/mobile-sheet-cta-hidden

@matticbot matticbot added the [Size] S Small sized issue label May 3, 2017
budzanowski
budzanowski approved these changes May 3, 2017
View reviewed changes
Copy link
Contributor

@budzanowski budzanowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fditrapani
Copy link
Contributor

Tested and confirmed. Looks great! 🚢

@folletto folletto merged commit b8f194f into master May 3, 2017
@folletto folletto deleted the fix/themes/mobile-sheet-cta-hidden branch May 3, 2017 13:57
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 3, 2017
@jsnajdr jsnajdr mentioned this pull request Jul 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budzanowski budzanowski budzanowski approved these changes

Assignees

@folletto folletto

Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Size] S Small sized issue [Type] Bug
Projects
None yet
Milestone
Themes: Showcase M6-TheOne
Development

Successfully merging this pull request may close these issues.
4 participants
@folletto @matticbot @fditrapani @budzanowski