Reader Manage Following: present a follow button if user appears to have entered a URL #13715

bluefuton · 2017-05-05T16:34:31Z

As outlined in #12950, present a follow button rather than search results if the user has entered a URL in the search input on Manage Following:

matticbot · 2017-05-05T16:34:32Z

Test live: https://calypso.live/?branch=add/reader/following-manage-search-by-url

bluefuton · 2017-05-05T17:40:23Z

Todo:

prepend protocol if it's missing from siteUrl (follow will fail otherwise)
conversely, omit the protocol from the label (so we don't get "Follow http://www.example.com")

samouri · 2017-05-08T14:02:01Z

client/reader/following-manage/url-helper.js

@@ -0,0 +1,43 @@
+/**


I think we should squint at this file a bit and try to merge it with /lib/url/index.js

isUrl is brand new, but the others looks like they may exist with a different name

samouri · 2017-05-08T14:39:41Z

try and do 'you're already following that feed' without a trip to the API?

@blowery merged in a selector that should be able to grab that data! isFollowing( state, { feedUr, feedId, blogId })

bluefuton · 2017-05-08T14:58:46Z

Todo in followup PRs:

handle invalid_feed response from API, and display error message (Reader: new follows are placed in Redux state, even if the feed did not exist #13726)
improve UX on successful follow?
keyboard shortcut for return/enter/submit

…ng and removing URL protocol

samouri · 2017-05-08T15:40:39Z

client/lib/url/test/index.js

@@ -285,3 +286,30 @@ describe( 'urlToSlug()', () => {
 		expect( urlWithoutHttp ).to.equal( 'example.com::example::test123' );
 	} );
 } );
+
+describe( 'resemblesUrl()', () => {


beautiful.
this entire commit is beautiful

blowery · 2017-05-08T15:53:12Z

client/lib/url/index.js

+
+	// Make sure the query has a protocol - hostname ends up blank otherwise
+	if ( ! parsedUrl.protocol ) {
+		parsedUrl = url.parse( 'http://' + query );


we may also want to verify that it's a protocol we support or can switch to. For example, gopher:// would be invalid, but we could switch feed:// to http://

That's a cool idea. I won't do it in this particular spot (resemblesUrl) because it might be reused by other things, but worth us keeping in mind.

blowery · 2017-05-08T15:55:30Z

client/lib/url/test/index.js

+	} );
+
+	it( 'should return false if the string is not a URL', () => {
+		const source = 'exampledotcom';


other test cases:
..com
. . .com
...com
.
<unicode non breaking spaces>.com

Added some extras in e1aa849 👍

samouri · 2017-05-08T15:56:21Z

there something funky going on with the generated url. Sample action dispatched:

{
  type: 'READER_RECORD_FOLLOW',
  payload: {
    url: 'undefined://google.com
  }
}

bluefuton · 2017-05-08T15:59:03Z

there something funky going on with the generated url

Ah - addSchemeIfMissing needs the scheme provided, so it works slightly differently to the function it replaced. I'll fix 👍

jancavan · 2017-05-08T20:27:57Z

This happens in <660px. Fixed in: 86f14aa

~~@bluefuton It doesn't follow the site when I hit enter?~~
Nvm, just read this 😄

keyboard shortcut for return/enter/submit

samouri · 2017-05-08T21:58:55Z

giving this another test and if all looks good I'll 🚢 .

samouri · 2017-05-08T22:11:15Z

testing checked out.

samouri · 2017-05-08T22:21:06Z

client/reader/following-manage/index.jsx

@@ -94,7 +97,7 @@ class FollowingManage extends Component {
 		this.resizeSearchBox();

 		// this is a total hack. In React-Virtualized you need to tell a WindowScroller when the things
-		// above it has moved with a call to updatePosision().  Our issue is we don't have a good moment
+		// above it has moved with a call to updatePosition().  Our issue is we don't have a good moment


didn't notice this before. thanks for the typo fix :)

Present a follow button if user appears to have entered a URL

6deef81

bluefuton added [Feature] Reader The reader site on Calypso. [Status] In Progress labels May 5, 2017

bluefuton added this to the Reader: Manage Following Refresh milestone May 5, 2017

bluefuton self-assigned this May 5, 2017

matticbot added the [Size] M Medium sized issue label May 5, 2017

Basic styling

15915c4

bluefuton mentioned this pull request May 5, 2017

Reader: new follows are placed in Redux state, even if the feed did not exist #13726

Closed

Prepend protocol for actual follow, and strip for label

95930d4

matticbot added [Size] L Large sized issue and removed [Size] M Medium sized issue labels May 5, 2017

Add following label

a370dee

samouri reviewed May 8, 2017

View reviewed changes

Move URL detection into lib/url and reuse existing functions for addi…

49cdb44

…ng and removing URL protocol

bluefuton added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels May 8, 2017

samouri reviewed May 8, 2017

View reviewed changes

blowery reviewed May 8, 2017

View reviewed changes

Fix call to addSchemeIfMissing

5dc0c75

bluefuton added [Status] Needs Author Reply and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 8, 2017

Added some additional test cases

e1aa849

bluefuton added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label May 8, 2017

bluefuton removed the [Status] Needs Author Reply label May 8, 2017

jancavan added 2 commits May 8, 2017 13:15

Fix padding

849bf8f

Add Follow text in <660px

86f14aa

samouri reviewed May 8, 2017

View reviewed changes

samouri added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels May 8, 2017

samouri merged commit 23486db into master May 8, 2017

samouri deleted the add/reader/following-manage-search-by-url branch May 8, 2017 22:23

matticbot removed the [Status] Ready to Merge label May 8, 2017

This was referenced May 30, 2021

[Snyk] Fix for 1 vulnerabilities ajesse11x/wp-calypso#52

Open

[Snyk] Security upgrade @wordpress/editor from 9.0.11 to 9.1.0 awaisab172/wp-calypso#79

Open

This was referenced Oct 24, 2021

[Snyk] Security upgrade @wordpress/editor from 9.0.11 to 9.1.0 awaisab172/wp-calypso#101

Open

[Snyk] Fix for 1 vulnerabilities ajesse11x/wp-calypso#65

Open

snyk-bot mentioned this pull request Nov 4, 2021

[Snyk] Fix for 1 vulnerabilities ajesse11x/wp-calypso#66

Open

ajesse11x mentioned this pull request Oct 20, 2023

[Snyk] Fix for 2 vulnerabilities ajesse11x/wp-calypso#93

Open

awaisab172 mentioned this pull request Oct 20, 2023

[Snyk] Security upgrade @wordpress/editor from 9.0.11 to 9.1.0 awaisab172/wp-calypso#162

Open

ajesse11x mentioned this pull request Nov 16, 2023

[Snyk] Fix for 2 vulnerabilities ajesse11x/wp-calypso#95

Open

awaisab172 mentioned this pull request Nov 17, 2023

[Snyk] Security upgrade @wordpress/editor from 9.0.11 to 9.1.0 awaisab172/wp-calypso#167

Open

awaisab172 mentioned this pull request Mar 27, 2024

[Snyk] Security upgrade @wordpress/editor from 9.0.11 to 9.1.0 awaisab172/wp-calypso#188

Open

ajesse11x mentioned this pull request Mar 28, 2024

[Snyk] Fix for 2 vulnerabilities ajesse11x/wp-calypso#102

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reader Manage Following: present a follow button if user appears to have entered a URL #13715

Reader Manage Following: present a follow button if user appears to have entered a URL #13715

bluefuton commented May 5, 2017

matticbot commented May 5, 2017

bluefuton commented May 5, 2017 •

edited

Loading

samouri May 8, 2017 •

edited

Loading

samouri commented May 8, 2017

bluefuton commented May 8, 2017

samouri May 8, 2017

blowery May 8, 2017

bluefuton May 8, 2017

blowery May 8, 2017 •

edited

Loading

bluefuton May 8, 2017

samouri commented May 8, 2017

bluefuton commented May 8, 2017

jancavan commented May 8, 2017 •

edited

Loading

samouri commented May 8, 2017

samouri commented May 8, 2017 •

edited

Loading

samouri May 8, 2017

Reader Manage Following: present a follow button if user appears to have entered a URL #13715

Reader Manage Following: present a follow button if user appears to have entered a URL #13715

Conversation

bluefuton commented May 5, 2017

matticbot commented May 5, 2017

bluefuton commented May 5, 2017 • edited Loading

samouri May 8, 2017 • edited Loading

Choose a reason for hiding this comment

samouri commented May 8, 2017

bluefuton commented May 8, 2017

samouri May 8, 2017

Choose a reason for hiding this comment

blowery May 8, 2017

Choose a reason for hiding this comment

bluefuton May 8, 2017

Choose a reason for hiding this comment

blowery May 8, 2017 • edited Loading

Choose a reason for hiding this comment

bluefuton May 8, 2017

Choose a reason for hiding this comment

samouri commented May 8, 2017

bluefuton commented May 8, 2017

jancavan commented May 8, 2017 • edited Loading

samouri commented May 8, 2017

samouri commented May 8, 2017 • edited Loading

samouri May 8, 2017

Choose a reason for hiding this comment

bluefuton commented May 5, 2017 •

edited

Loading

samouri May 8, 2017 •

edited

Loading

blowery May 8, 2017 •

edited

Loading

jancavan commented May 8, 2017 •

edited

Loading

samouri commented May 8, 2017 •

edited

Loading