Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Framework: Make disabled text field readable in Safari iOS #1513

Merged
merged 1 commit into from
Dec 13, 2015

Conversation

kellychoffman
Copy link
Member

Fixes: #177 (Props @v18)

Effects disabled text fields in Safari iOS.

Before:
screen shot 2015-12-11 at 12 56 26 pm

After:
screen shot 2015-12-11 at 12 56 17 pm

Now comparable to Mac 'n Chrome, for example:
screen shot 2015-12-11 at 1 07 11 pm

@kellychoffman kellychoffman added Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Janitorial labels Dec 11, 2015
@kellychoffman kellychoffman self-assigned this Dec 11, 2015
@sirbrillig
Copy link
Member

Nice! LGTM!

@sirbrillig sirbrillig added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 11, 2015
kellychoffman added a commit that referenced this pull request Dec 13, 2015
Framework: Make disabled text field readable in Safari iOS
@kellychoffman kellychoffman merged commit 5f332e0 into master Dec 13, 2015
@kellychoffman
Copy link
Member Author

Thanks for the review @sirbrillig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants