Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calypso & wp-admin isomorphic extensions #15243

Closed
wants to merge 1 commit into from

Conversation

johnHackworth
Copy link
Contributor

Continues the work from #11620

The intent of this PR is to build an example of an extension that can be used both in calypso and wp-admin, so we could use a single codebase to build both versions of a plugin.

It requires a small php plugin on wp-admin side to work: https://gist.github.com/johnHackworth/73cc8f8bf11e8459544e2361e36eb9e5

How to test:

  1. You will need to edit JETPACK_DIR in bin/copy-files.sh to add the path where your js bundles are going to be exported (probably you want them to be in the local mirror of the path where the PHP plugin sits)
    0.5 Copy the php plugin in your test site plugins folder and activate it
  2. Run npm run build-jetpack && ./bin/copy-files.sh
  3. Sync your files to your remote site
  4. Run calypso locally
  5. In your remote site, you should have a new wp-admin menu item "jetpack-ui" you can click to get to the extension
  6. In your local calypso, you can go to http://calypso.localhost:3000/test to see the same extension working on calypso

@johnHackworth johnHackworth added Extensions Jetpack [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Jun 19, 2017
@johnHackworth johnHackworth self-assigned this Jun 19, 2017
@matticbot
Copy link
Contributor

@matticbot matticbot added the [Size] XL Probably needs to be broken down into multiple smaller issues label Jun 19, 2017
@matticbot
Copy link
Contributor

@johnHackworth This PR needs a rebase

@ockham
Copy link
Contributor

ockham commented Aug 3, 2017

Alternative approach at Automattic/WP-Job-Manager#1108 and #16782.

@apeatling
Copy link
Member

@johnHackworth Is this PR still relevant based on the alternative approach posted above? If not, let's close it.

@johnHackworth
Copy link
Contributor Author

@apeatling this was more an exploration than anything else... so yeah, let's close it

@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Nov 8, 2017
@lancewillett lancewillett deleted the try/extensions-build branch November 15, 2017 23:33
@ryelle ryelle restored the try/extensions-build branch February 6, 2018 21:55
@lancewillett lancewillett deleted the try/extensions-build branch February 20, 2018 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extensions Jetpack [Size] XL Probably needs to be broken down into multiple smaller issues [Status] Needs Rebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants