Reinstate: Signup: Free trials: Only show free trials on signup in the dev environment #1526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Status] In Progress
[Feature] Signup & Account Creation
scruffian
added
[Status] Needs Review
|
LGTM 👍 |
|
Code looks good and works fine. I tested signup with a Premium free trial while sandboxed and proxied, and a signup with a free plan (with free trials disabled). |
stephanethomas
added
[Status] Ready to Merge
and removed
[Status] Needs Review
…in the dev environment""
scruffian
force-pushed
the
revert-1525-revert-1423-update/1417-free-trials-in-signup
branch
from
213b8f8 to
8056c12
Compare
scruffian
added a commit
that referenced
this pull request
Dec 16, 2015
…te/1417-free-trials-in-signup Reinstate: Signup: Free trials: Only show free trials on signup in the dev environment
scruffian
deleted the
revert-1525-revert-1423-update/1417-free-trials-in-signup
branch
This was referenced Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change broke signups in production because we were trying to create a payment button for free plans.
Testing
You should test this with the
upgrades/free-trialsflag set to bothtrueandfalseinconfig/development.jsonand restartmake runevery time you change it.You should be able to go through the signup flow either way; but you will not see free trials when it is false.