Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help: Increase font size in Happiness Engineer text #1570

Merged
merged 1 commit into from
Dec 15, 2015
Merged

Conversation

dllh
Copy link
Member

@dllh dllh commented Dec 14, 2015

The font size is a little small at narrower widths, and this makes it a little friendlier to read at smaller screen sizes.

Repro:

  1. Visit http://calypso.localhost:3000/help/
  2. Observe the list of Happiness Engineers at the bottom
  3. Reduce screen size to a width narrower than 660px.
  4. Observe the font size of the text underneath "We care about your happiness"

This would fix #1390. Before the fix:

screen shot

With the fix:

screen shot 2015-12-14 at 4 12 32 pm

@dllh dllh added [Status] In Progress Live Chat [Feature Group] Support All things related to WordPress.com customer support. labels Dec 14, 2015
@dllh dllh self-assigned this Dec 14, 2015
…ngineers. It's a little small at narrower widths, and this makes it a little friendlier to read at smaller screen sizes.
@dllh dllh force-pushed the update/chat-style branch from 6cbf814 to 493bf00 Compare December 14, 2015 21:18
@dllh dllh added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Dec 14, 2015
@dllh
Copy link
Member Author

dllh commented Dec 14, 2015

Cc @mattmiklic @omarjackman

@omarjackman
Copy link
Contributor

👍 This looks good to me

@mattmiklic
Copy link
Member

Looks good 👍 11px is too small for paragraph text; that was my mistake in the initial mockup.

@dllh dllh added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 15, 2015
dllh added a commit that referenced this pull request Dec 15, 2015
Help: Increase font size in Happiness Engineer text
@dllh dllh merged commit 9d78004 into master Dec 15, 2015
@dllh dllh deleted the update/chat-style branch December 15, 2015 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] Support All things related to WordPress.com customer support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help: Happiness Engineer list description is small on mobile
4 participants