Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reader FeaturedImage/Video: introduce min height #17659

Closed
wants to merge 1 commit into from
Closed

Reader FeaturedImage/Video: introduce min height #17659

wants to merge 1 commit into from

Conversation

samouri
Copy link
Contributor

@samouri samouri commented Aug 30, 2017

this is just a test, don't mind me.

@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=try/reader/image-video-minheight

@matticbot matticbot added the [Size] S Small sized issue label Aug 30, 2017
@samouri samouri added [Feature] Reader The reader site on Calypso. [Status] In Progress labels Aug 30, 2017
@aaronyan
Copy link
Member

Interesting. I see the dilemma now. There's lots of white space if we include a min height.

Current settings:

small_video_box

With min height:

min_height

@samouri samouri closed this Aug 31, 2017
@samouri samouri deleted the try/reader/image-video-minheight branch August 31, 2017 01:08
@samouri
Copy link
Contributor Author

samouri commented Aug 31, 2017

Interesting. I see the dilemma now. There's lots of white space if we include a min height.

closed for ^ reason

This was referenced May 15, 2021
Open
Open
This was referenced Oct 1, 2023
Open
Open
@awaisab172 awaisab172 mentioned this pull request Oct 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Feature] Reader The reader site on Calypso. [Size] S Small sized issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samouri @matticbot @aaronyan